hmtl: Add a test for an autofocus issue with <dialog>#19151
Merged
Conversation
3 tasks
foolip
approved these changes
Sep 19, 2019
Member
foolip
left a comment
There was a problem hiding this comment.
Compact and to the point, nice test. LGTM % nit
| promise_test(async () => { | ||
| const dialog = document.querySelector('dialog'); | ||
| dialog.show(); | ||
| assert_equals(document.activeElement, dialog.querySelector('[autofocus]')); |
Member
There was a problem hiding this comment.
Can you add descriptions so that you tell which assert failed if there's a failure?
Member
|
Spec change is whatwg/html#4918. |
domenic
pushed a commit
to whatwg/html
that referenced
this pull request
Nov 7, 2019
When the dialog focusing steps are called, we prevent further autofocusing for the document. This fixes #4788. Tests: web-platform-tests/wpt#19151
domenic
approved these changes
Nov 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
whatwg/html#4788