Skip to content

new html month input test fiels from TestTWF.#171

Closed
kaseijin wants to merge 2 commits intoweb-platform-tests:masterfrom
kaseijin:submissions/kaseijin
Closed

new html month input test fiels from TestTWF.#171
kaseijin wants to merge 2 commits intoweb-platform-tests:masterfrom
kaseijin:submissions/kaseijin

Conversation

@kaseijin
Copy link
Contributor

@kaseijin kaseijin commented Jun 8, 2013

No description provided.

@odinho
Copy link
Contributor

odinho commented Jun 8, 2013

This looks good. But it will have to be merged with #155. Care to find out what/how? I can merge that other test when the assert_not_equals are changed. It'll be easier to add to that test then (although it's possible even now, with some basic git trickery)

@odinho
Copy link
Contributor

odinho commented Jun 8, 2013

#155 is merged now, so the improvements from this pull request should be put on top of that file. Because they conflict now. :)

Most of these tests can just be ported, only a few dupes. And maybe you can also add a step-test with a non-integer value (so e.g. step=2.3 plus stepUp check new value)

@kaseijin
Copy link
Contributor Author

kaseijin commented Jun 8, 2013

@velmont It failed to merge the file propery.
I will send a new request. So, don't merge this request.

@kaseijin kaseijin closed this Jun 8, 2013
@odinho
Copy link
Contributor

odinho commented Jun 8, 2013

yeah, you should probably have done a rebase on top.

git fetch
git rebase master

But just do it by creating a new fresh branch yes :-)

@kaseijin
Copy link
Contributor Author

kaseijin commented Jun 8, 2013

About min, max attributes, I asked other experts and they said that it does not matter if those attributes are valid or not. It should just ignore it and act as if it does not exist.
(They said that we should focus month value like that.)

jgraham pushed a commit that referenced this pull request Apr 21, 2017
Implement WebDriver specification test harness for Firefox
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants