Give all Travis jobs human-readable names#13300
Conversation
Also make travis.yml more consistent around `os` and `python`.
|
I did this because I've been unable to understand what some of the jobs are from a view like https://travis-ci.org/web-platform-tests/wpt/builds/435826707. https://travis-ci.org/web-platform-tests/wpt/builds/435843332 shows what this would look like. |
.travis.yml
Outdated
| fast_finish: true | ||
| include: | ||
| - os: linux | ||
| - name: "manifest upload" |
There was a problem hiding this comment.
Should I add "(no-op for PR)" or something to this description?
.travis.yml
Outdated
| - libnss3-tools | ||
| env: JOB=wpt_integration TOXENV=py27,py27-flake8 SCRIPT=tools/ci/ci_wpt.sh | ||
| - os: linux | ||
| - name: "wptrunner infrastructure" |
There was a problem hiding this comment.
Is this a good name? Are these unit tests, or what?
There was a problem hiding this comment.
This runs pytest in tools/wpt
There was a problem hiding this comment.
Hmm, that doesn't seem quite right. The only place pytest appears in tools/ci is in tools/ci/tests/test_jobs.py, and this job will run tools/ci/ci_wptrunner_infrastructure.sh. Looks like it will run infrastructure/ in chrome and firefox, using in-tree expectations. Am I reading that right?
If so, maybe call it "infrastructure/ tests"? I'll throw on a slash on some of the other names too for consistency.
jgraham
left a comment
There was a problem hiding this comment.
Oh, I didn't know about this.
.travis.yml
Outdated
| python: "2.7" | ||
| env: JOB=resources_unittest TOXENV=py27 SCRIPT=tools/ci/ci_resources_unittest.sh | ||
| - python: 2.7 | ||
| - name: "flake8" |
There was a problem hiding this comment.
I'm now pretty sure I've misnamed this one. This does involve tools/wpt and is probably what @jgraham referred to in https://github.com/web-platform-tests/wpt/pull/13300/files#r221878898. This does run flake8, but also other things it seems. @gsnedders, what should it be called? "tools/wpt/ pytest + flake8"?
There was a problem hiding this comment.
"wpt unittests", for consistency with all the other unittests jobs? (Or "wpi cli unittests", if that's unclear?)
There was a problem hiding this comment.
"wpt cli unittests" would be much clearer IMO
There was a problem hiding this comment.
Or even tools/wpt/ unittests to be consistent with the above?
There was a problem hiding this comment.
I'll go with tools/wpt/ unittests, if they are indeed accurate described as unit tests.
|
Does anyone know why we run flake8 the way we do, and not as part of the lint, say? Would it be reasonable to restructure the jobs to run flake8 as part of the lint job? (I'd just file a follow-up issue, not here.) |
|
Making the lint just run |
|
So, it seems like we run flake8 as part of 3 tox.ini files, run in 2 different jobs: That's kind of weird, but I'll just leave it alone in this PR. However, poking around I noticed that "resources/ unittests" is not pedantically correct, as resources/test/tests/ has both functional and unit subdirectories. I'll just call it "resources/ tests". |
|
OK, I've tinkered a bit more, changed the order to make it read better. Enough tinkering, now merging. Please shout at me if you don't like the names :) |
|
This is great! |
Also make travis.yml more consistent about the use/quoting of `os` and `python` and make order nicer given the new names.
Also make travis.yml more consistent around
osandpython.