PaymentRequest: Implement desktop UI for PaymentResponse.retry()#12550
Merged
marcoscaceres merged 1 commit intomasterfrom Aug 21, 2018
Merged
PaymentRequest: Implement desktop UI for PaymentResponse.retry()#12550marcoscaceres merged 1 commit intomasterfrom
marcoscaceres merged 1 commit intomasterfrom
Conversation
wpt-pr-bot
approved these changes
Aug 17, 2018
Collaborator
wpt-pr-bot
left a comment
There was a problem hiding this comment.
Already reviewed downstream.
Related spec change: w3c/payment-request#721 Tests: components/payments/content/payment_request_spec_unittest.cc components/payments/content/payment_request_state_unittest.cc Manual tests: wpt/payment-request/payment-response/retry-method-manual.https.html wpt/payment-request/PaymentValidationErrors/retry-shows-shippingAddress-member-manual.https.html wpt/payment-request/PaymentValidationErrors/retry-shows-payer-member-manual.https.html Demo: https://youtu.be/_mbcGkbwfw8 Bug: 861704 Change-Id: I12c2d74f7b170626d2c9a41ecfc9116bfe75c2b7
7d102b4 to
ba3f10e
Compare
marcoscaceres
approved these changes
Aug 21, 2018
zcorpan
pushed a commit
that referenced
this pull request
Aug 27, 2018
) Related spec change: w3c/payment-request#721 Tests: components/payments/content/payment_request_spec_unittest.cc components/payments/content/payment_request_state_unittest.cc Manual tests: wpt/payment-request/payment-response/retry-method-manual.https.html wpt/payment-request/PaymentValidationErrors/retry-shows-shippingAddress-member-manual.https.html wpt/payment-request/PaymentValidationErrors/retry-shows-payer-member-manual.https.html Demo: https://youtu.be/_mbcGkbwfw8 Bug: 861704 Change-Id: I12c2d74f7b170626d2c9a41ecfc9116bfe75c2b7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related spec change:
w3c/payment-request#721
Tests:
components/payments/content/payment_request_spec_unittest.cc
components/payments/content/payment_request_state_unittest.cc
Manual tests:
wpt/payment-request/payment-response/retry-method-manual.https.html
wpt/payment-request/PaymentValidationErrors/retry-shows-shippingAddress-member-manual.https.html
wpt/payment-request/PaymentValidationErrors/retry-shows-payer-member-manual.https.html
Demo:
https://youtu.be/_mbcGkbwfw8
Bug: 861704
Change-Id: I12c2d74f7b170626d2c9a41ecfc9116bfe75c2b7
Reviewed-on: https://chromium-review.googlesource.com/1144587
WPT-Export-Revision: ae0928e0dedea745a3b01f842e13b0af5dbf0989