Add a basic TextTrackList.getTrackById test#1058
Merged
foolip merged 1 commit intoweb-platform-tests:masterfrom Jun 12, 2014
Merged
Add a basic TextTrackList.getTrackById test#1058foolip merged 1 commit intoweb-platform-tests:masterfrom
foolip merged 1 commit intoweb-platform-tests:masterfrom
Conversation
Unfortunately in-band tracks are required to get a non-empty id, so this is the extent of testing currently possible.
|
Critic review: https://critic.hoppipolla.co.uk/r/1802 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
foolip
added a commit
that referenced
this pull request
Jun 12, 2014
Add a basic TextTrackList.getTrackById test
gsnedders
pushed a commit
that referenced
this pull request
Mar 28, 2017
Cleanup CaretPosition-001.html.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately in-band tracks are required to get a non-empty
id, so this is the extent of testing currently possible.