Skip to content

fix: call invalid hook for watching.invalidateWithChangesAndRemovals()#9789

Merged
ahabhgk merged 5 commits intomainfrom
rename-lazy-compilation-invalid
Mar 25, 2025
Merged

fix: call invalid hook for watching.invalidateWithChangesAndRemovals()#9789
ahabhgk merged 5 commits intomainfrom
rename-lazy-compilation-invalid

Conversation

@ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Mar 25, 2025 •
edited
Loading

Summary

  1. rename watching.invalidateWithChangedFiles to watching.invalidateWithChangesAndRemovals, and mark it as internal (need more time to tell it's stable or not)
  2. call invalid hook for watching.invalidateWithChangesAndRemovals()

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Mar 25, 2025
@ahabhgk ahabhgk requested a review from JSerFeng March 25, 2025 05:02
@netlify
Copy link

netlify bot commented Mar 25, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 2cb178d
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67e2387cd8d29d0008c22780

@ahabhgk ahabhgk enabled auto-merge (squash) March 25, 2025 05:04
@netlify
Copy link

netlify bot commented Mar 25, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 41aa275
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67e251182aff6a0008067deb

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 25, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9789 will not alter performance

Comparing rename-lazy-compilation-invalid (41aa275) with main (fd080d9)

Summary

✅ 8 untouched benchmarks

JSerFeng
JSerFeng previously approved these changes Mar 25, 2025
View reviewed changes
@ahabhgk ahabhgk requested a review from JSerFeng March 25, 2025 06:46
@ahabhgk ahabhgk changed the title refactor: call invalid hook for lazyCompilationInvalidate and rename to more general fix: call invalid hook for invalidateWithChangesAndRemovals Mar 25, 2025
@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Mar 25, 2025
@ahabhgk ahabhgk changed the title fix: call invalid hook for invalidateWithChangesAndRemovals fix: call invalid hook for watching.invalidateWithChangesAndRemovals() Mar 25, 2025
@ahabhgk ahabhgk disabled auto-merge March 25, 2025 06:53
@ahabhgk ahabhgk enabled auto-merge (squash) March 25, 2025 06:54
@ahabhgk ahabhgk merged commit 23aa5ae into main Mar 25, 2025
37 checks passed
@ahabhgk ahabhgk deleted the rename-lazy-compilation-invalid branch March 25, 2025 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JSerFeng JSerFeng JSerFeng approved these changes

Assignees

No one assigned

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ahabhgk @JSerFeng