Skip to content

fix: array in asset info#9774

Merged
SyMind merged 1 commit intomainfrom
asset-info
Mar 24, 2025
Merged

fix: array in asset info#9774
SyMind merged 1 commit intomainfrom
asset-info

Conversation

@SyMind
Copy link
Member

@SyMind SyMind commented Mar 24, 2025

Summary

compilation.emitAsset("/foo.txt", new compiler.webpack.sources.RawSource("foo"), {
    additionalKeys: ["foo", "bar"],
});

additionalKeys will transform to the array like object {0: "foo", 1: "bar"}. but we expected the array.

The reason is Rust not transform js array right.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link

netlify bot commented Mar 24, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 2c6df54
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67e11222b34a7b00088d26c0

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Mar 24, 2025
@SyMind SyMind marked this pull request as ready for review March 24, 2025 07:56
@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Mar 24, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 24, 2025

CodSpeed Performance Report

Merging #9774 will not alter performance

Comparing asset-info (2c6df54) with main (b03c2e5)

Summary

✅ 8 untouched benchmarks

@SyMind SyMind merged commit 2d7c8da into main Mar 24, 2025
56 of 57 checks passed
@SyMind SyMind deleted the asset-info branch March 24, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants