Skip to content

fix: getter and setter type in module subtype#9772

Merged
SyMind merged 1 commit intomainfrom
fix-module-ty
Mar 24, 2025
Merged

fix: getter and setter type in module subtype#9772
SyMind merged 1 commit intomainfrom
fix-module-ty

Conversation

@SyMind
Copy link
Member

@SyMind SyMind commented Mar 24, 2025

Summary

  1. request, resource, userRequest, rawRequest, loaders in NormalModule should not be undefined.
  2. modules in ConcatenatedModule should not be undefined.
  3. userRequest in ExternalModule should not be undefined.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Mar 24, 2025
@netlify
Copy link

netlify bot commented Mar 24, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit b180873
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67e0e18695b6910008a450fd

@SyMind SyMind marked this pull request as ready for review March 24, 2025 04:39
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 24, 2025

CodSpeed Performance Report

Merging #9772 will not alter performance

Comparing fix-module-ty (b180873) with main (e5f16e2)

🎉 Hooray! codspeed-node just leveled up to 4.0.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 8 untouched benchmarks

@SyMind SyMind merged commit ae0330b into main Mar 24, 2025
37 checks passed
@SyMind SyMind deleted the fix-module-ty branch March 24, 2025 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants