Skip to content

feat: introduce par_iter_then_collect#9736

Merged
hardfist merged 1 commit intoweb-infra-dev:mainfrom
quininer:par_iter_then_collect
Mar 20, 2025
Merged

feat: introduce par_iter_then_collect#9736
hardfist merged 1 commit intoweb-infra-dev:mainfrom
quininer:par_iter_then_collect

Conversation

@quininer
Copy link
Contributor

@quininer quininer commented Mar 19, 2025

Summary

This PR introduces par_iter_then_collect to provide rayon-like par_iter().collect() feature, but async. this is implemented based on rspack_futures::scope, so it requires unsafe.

cc @hardfist

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link

netlify bot commented Mar 19, 2025

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 1c62be0
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67da8e2ab2f7ba0008c93a48

@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Mar 19, 2025
@quininer quininer force-pushed the par_iter_then_collect branch 2 times, most recently from 97ab9f4 to 811c5fa Compare March 19, 2025 08:35
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 19, 2025

CodSpeed Performance Report

Merging #9736 will not alter performance

Comparing quininer:par_iter_then_collect (1c62be0) with main (8444006)

Summary

✅ 8 untouched benchmarks

@quininer quininer force-pushed the par_iter_then_collect branch from 811c5fa to 1c62be0 Compare March 19, 2025 09:28
@quininer quininer marked this pull request as ready for review March 20, 2025 07:19
@hardfist hardfist merged commit 9430ec7 into web-infra-dev:main Mar 20, 2025
31 checks passed
@quininer quininer deleted the par_iter_then_collect branch March 20, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: feature release: feature related release(mr only)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants