Skip to content

fix: revoke dependency clean dependency at module and block#9638

Merged
jerrykingxyz merged 3 commits intomainfrom
jerry/test
Mar 12, 2025
Merged

fix: revoke dependency clean dependency at module and block#9638
jerrykingxyz merged 3 commits intomainfrom
jerry/test

Conversation

@jerrykingxyz
Copy link
Contributor

@jerrykingxyz jerrykingxyz commented Mar 12, 2025 •
edited
Loading

Summary

  1. mg.revoke_dependency will clean dependency at module and block when the force parameter is true
impl ModuleGraph {
  fn revoke_dependency(&mut self, dep_id: &DependencyId) {
    ...
    if force {
      original_module.remove_dependency_id(dep_id);
      parent_block.remove_dependency_id(dep_id);
    }
  }
}
  1. optimize ModernModule finish_make hook code, remove useless clone and module queries.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Mar 12, 2025
@jerrykingxyz jerrykingxyz linked an issue Mar 12, 2025 that may be closed by this pull request
[Bug]: When buildCache is enabled, encountering lazy import paths or barrel files causes a panic at runtime #9605
Closed
@netlify
Copy link

netlify bot commented Mar 12, 2025 •
edited
Loading

✅ Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 35b8085
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67d15576adb343000866e37b
😎 Deploy Preview https://deploy-preview-9638--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 12, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9638 will not alter performance

Comparing jerry/test (35b8085) with main (2484a56)

Summary

✅ 8 untouched benchmarks

@jerrykingxyz jerrykingxyz requested a review from fi3ework March 12, 2025 10:30
@fi3ework
Copy link
Member

fi3ework commented Mar 12, 2025

I tested Rslib locally it's all good, and the code is much cleaner now. Great work.

@jerrykingxyz jerrykingxyz merged commit bf98eda into main Mar 12, 2025
31 checks passed
@jerrykingxyz jerrykingxyz deleted the jerry/test branch March 12, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fi3ework fi3ework fi3ework approved these changes

Assignees

No one assigned

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: When buildCache is enabled, encountering lazy import paths or barrel files causes a panic at runtime

2 participants

@jerrykingxyz @fi3ework