fix(core): use future_scope to run parallel future#9637
Merged
hardfist merged 2 commits intoweb-infra-dev:mainfrom Mar 13, 2025
Merged
fix(core): use future_scope to run parallel future#9637hardfist merged 2 commits intoweb-infra-dev:mainfrom
hardfist merged 2 commits intoweb-infra-dev:mainfrom
Conversation
✅ Deploy Preview for rspack ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
b9e4cdf to
e61ebc5
Compare
CodSpeed Performance ReportMerging #9637 will not alter performanceComparing Summary
|
dbf411f to
e4bf660
Compare
e4bf660 to
00372f2
Compare
h-a-n-a
approved these changes
Mar 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
future_scope is more safe than async_scope cause you need explicitly pass ref to it and reviewer just need to review whether the passed ref is still valid during future execution
Checklist