feat(memory-cache): add maxGenerations support#9517
Merged
Conversation
✅ Deploy Preview for rspack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
CodSpeed Performance ReportMerging #9517 will not alter performanceComparing Summary
|
jerrykingxyz
approved these changes
Feb 28, 2025
Contributor
Author
This was referenced Feb 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Close #9405
Added
maxGenerationssupport for memory cache. By default,maxGenerationsis set to 1.The option is used to define how many cycles memory cache will survive if it's not being accessed to in future generations:
With
max_generationsset to x, the cache was generated on generation y, will be removed on generation x + y + 1.For example: Cache created on generation 0 will be removed on generation 2 with
max_generationsset to 1, if it's not accessed on generation 1.This option is not being exposed to users for now, as the cache key is encoded with hash, resulting it's not likely to be reused between compilations if it's source was changed.
Lifting memory consumption in #8976 (comment)
Checklist