Skip to content

fix: persistent cache skip calc modified_files when rebuild#9448

Merged
jerrykingxyz merged 2 commits intomainfrom
jerry/pc
Feb 25, 2025
Merged

fix: persistent cache skip calc modified_files when rebuild#9448
jerrykingxyz merged 2 commits intomainfrom
jerry/pc

Conversation

@jerrykingxyz
Copy link
Contributor

@jerrykingxyz jerrykingxyz commented Feb 25, 2025 •
edited
Loading

Summary

Persistent cache calculation of modified_files should only be run in compilation.build. This PR will add a field at compilation to mark whether it is in a rebuild.

struct Compilation {
  // A flag indicating whether the current compilation is being rebuilt.
  is_rebuild: bool
}

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: bug fix release: bug related release(mr only) labels Feb 25, 2025
@netlify
Copy link

netlify bot commented Feb 25, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 5ab3aa3
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67bd90253897a5000827d14d

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 25, 2025

CodSpeed Performance Report

Merging #9448 will not alter performance

Comparing jerry/pc (5ab3aa3) with main (836b4a1)

Summary

✅ 7 untouched benchmarks

@jerrykingxyz jerrykingxyz merged commit aa14f1a into main Feb 25, 2025
27 checks passed
@jerrykingxyz jerrykingxyz deleted the jerry/pc branch February 25, 2025 10:32
@jerrykingxyz jerrykingxyz linked an issue Feb 25, 2025 that may be closed by this pull request
[Bug]: Rspack persistent cache doesn't work for code-generated files #9413
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@h-a-n-a h-a-n-a h-a-n-a approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Rspack persistent cache doesn't work for code-generated files

2 participants

@jerrykingxyz @h-a-n-a