Skip to content

refactor: remove duplicate static variable definitions#9443

Merged
ahabhgk merged 1 commit intoweb-infra-dev:mainfrom
inottn:refactor/property_access
Feb 25, 2025
Merged

refactor: remove duplicate static variable definitions#9443
ahabhgk merged 1 commit intoweb-infra-dev:mainfrom
inottn:refactor/property_access

Conversation

@inottn
Copy link
Copy Markdown
Collaborator

@inottn inottn commented Feb 24, 2025

Summary

They are redundantly defined in property_name and property_access, so one of them can be removed.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link
Copy Markdown

netlify bot commented Feb 24, 2025

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 185b431
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67bca92d4d15750008b71a4b

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Feb 24, 2025

CodSpeed Performance Report

Merging #9443 will not alter performance

Comparing inottn:refactor/property_access (185b431) with main (cf4d882)

Summary

✅ 7 untouched benchmarks

@chenjiahan chenjiahan requested a review from ahabhgk February 25, 2025 03:27
@ahabhgk ahabhgk merged commit 33b3a41 into web-infra-dev:main Feb 25, 2025
31 checks passed
@inottn inottn deleted the refactor/property_access branch February 25, 2025 03:41
@h-a-n-a h-a-n-a mentioned this pull request Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants