chore: move modern module library finish_modules to finish_make#9426
Merged
chore: move modern module library finish_modules to finish_make#9426
Conversation
✅ Deploy Preview for rspack canceled.
|
Contributor
Author
|
!eco-ci |
Contributor
|
⏳ Triggered ecosystem ci: Open |
CodSpeed Performance ReportMerging #9426 will not alter performanceComparing 🎉 Hooray!
|
Contributor
Author
|
Don't know why rsbuild hang in eco-ci, but it passes in my local |
fi3ework
approved these changes
Feb 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
finish_modules means the module graph (modules, connections, dependencies) are frozen and start to optimize (provided exports, infer async, etc.) based on the module graph, so any kind of change that affect these should be done before the finish_modules.
Checklist