Skip to content

perf: remove blocking for execute module hook#9406

Merged
ahabhgk merged 1 commit intomainfrom
async-exe-module-hoook
Feb 20, 2025
Merged

perf: remove blocking for execute module hook#9406
ahabhgk merged 1 commit intomainfrom
async-exe-module-hoook

Conversation

@ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Feb 20, 2025 •
edited
Loading

Summary

Remove the blocking call that running under make phase

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link

netlify bot commented Feb 20, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 9205bd3
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67b6c9a385ffa800089e30dd

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Feb 20, 2025
@ahabhgk ahabhgk requested a review from hardfist February 20, 2025 07:03
@ahabhgk ahabhgk changed the title chore: use async for execute module hook perf: remove blocking for execute module hook Feb 20, 2025
@github-actions github-actions bot added the release: performance release: performance related release(mr only) label Feb 20, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 20, 2025

CodSpeed Performance Report

Merging #9406 will not alter performance

Comparing async-exe-module-hoook (9205bd3) with main (8b1ebe5)

Summary

✅ 7 untouched benchmarks

@ahabhgk
Copy link
Contributor Author

ahabhgk commented Feb 20, 2025

!bench

@ahabhgk ahabhgk enabled auto-merge (squash) February 20, 2025 07:32
@github-actions
Copy link
Contributor

github-actions bot commented Feb 20, 2025 •
edited
Loading

📝 Benchmark detail: Open

Name Base (2025-02-20 2101c1b) Current Change
10000_big_production-mode_disable-minimize + exec 37.5 s ± 434 ms 38 s ± 461 ms +1.47 %
10000_development-mode + exec 1.73 s ± 37 ms 1.78 s ± 76 ms +3.12 %
10000_development-mode_hmr + exec 674 ms ± 4.7 ms 683 ms ± 28 ms +1.25 %
10000_production-mode + exec 2.21 s ± 43 ms 2.2 s ± 115 ms -0.09 %
10000_production-mode_persistent-cold + exec 2.35 s ± 168 ms 2.35 s ± 88 ms +0.09 %
10000_production-mode_persistent-hot + exec 1.59 s ± 22 ms 1.6 s ± 27 ms +0.43 %
arco-pro_development-mode + exec 1.75 s ± 105 ms 1.77 s ± 107 ms +0.97 %
arco-pro_development-mode_hmr + exec 385 ms ± 3.1 ms 385 ms ± 2.5 ms -0.04 %
arco-pro_production-mode + exec 3.57 s ± 201 ms 3.54 s ± 96 ms -0.78 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.65 s ± 103 ms 3.62 s ± 150 ms -0.76 %
arco-pro_production-mode_persistent-cold + exec 3.69 s ± 248 ms 3.69 s ± 166 ms -0.17 %
arco-pro_production-mode_persistent-hot + exec 2.33 s ± 131 ms 2.34 s ± 206 ms +0.49 %
arco-pro_production-mode_traverse-chunk-modules + exec 3.58 s ± 113 ms 3.53 s ± 41 ms -1.62 %
large-dyn-imports_development-mode + exec 1.98 s ± 26 ms 2.01 s ± 77 ms +1.86 %
large-dyn-imports_production-mode + exec 2.04 s ± 53 ms 2.07 s ± 79 ms +1.44 %
threejs_development-mode_10x + exec 1.51 s ± 24 ms 1.54 s ± 14 ms +1.61 %
threejs_development-mode_10x_hmr + exec 776 ms ± 34 ms 786 ms ± 26 ms +1.22 %
threejs_production-mode_10x + exec 5.2 s ± 394 ms 5.13 s ± 141 ms -1.35 %
threejs_production-mode_10x_persistent-cold + exec 5.27 s ± 332 ms 5.26 s ± 399 ms -0.24 %
threejs_production-mode_10x_persistent-hot + exec 4.44 s ± 275 ms 4.38 s ± 30 ms -1.47 %
10000_big_production-mode_disable-minimize + rss memory 8671 MiB ± 16.8 MiB 8669 MiB ± 42.9 MiB -0.02 %
10000_development-mode + rss memory 658 MiB ± 28.2 MiB 650 MiB ± 19 MiB -1.23 %
10000_development-mode_hmr + rss memory 1266 MiB ± 241 MiB 1342 MiB ± 163 MiB +6.02 %
10000_production-mode + rss memory 645 MiB ± 23.5 MiB 636 MiB ± 36.2 MiB -1.35 %
10000_production-mode_persistent-cold + rss memory 736 MiB ± 20.5 MiB 734 MiB ± 38.3 MiB -0.31 %
10000_production-mode_persistent-hot + rss memory 728 MiB ± 27.3 MiB 705 MiB ± 19 MiB -3.07 %
arco-pro_development-mode + rss memory 580 MiB ± 34.2 MiB 574 MiB ± 23.5 MiB -1.00 %
arco-pro_development-mode_hmr + rss memory 648 MiB ± 49.5 MiB 682 MiB ± 42.9 MiB +5.14 %
arco-pro_production-mode + rss memory 730 MiB ± 44.8 MiB 708 MiB ± 46.1 MiB -3.12 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory 740 MiB ± 22.9 MiB 725 MiB ± 29.1 MiB -2.00 %
arco-pro_production-mode_persistent-cold + rss memory 811 MiB ± 34.9 MiB 780 MiB ± 40.6 MiB -3.80 %
arco-pro_production-mode_persistent-hot + rss memory 671 MiB ± 24 MiB 627 MiB ± 22.1 MiB -6.55 %
arco-pro_production-mode_traverse-chunk-modules + rss memory 736 MiB ± 26.8 MiB 705 MiB ± 35.2 MiB -4.19 %
large-dyn-imports_development-mode + rss memory 652 MiB ± 3.22 MiB 633 MiB ± 3.34 MiB -2.92 %
large-dyn-imports_production-mode + rss memory 537 MiB ± 9.03 MiB 517 MiB ± 3.5 MiB -3.82 %
threejs_development-mode_10x + rss memory 550 MiB ± 25.2 MiB 553 MiB ± 16.9 MiB +0.60 %
threejs_development-mode_10x_hmr + rss memory 1091 MiB ± 142 MiB 1113 MiB ± 158 MiB +2.02 %
threejs_production-mode_10x + rss memory 825 MiB ± 47.2 MiB 827 MiB ± 34.6 MiB +0.22 %
threejs_production-mode_10x_persistent-cold + rss memory 931 MiB ± 39.6 MiB 917 MiB ± 56.2 MiB -1.52 %
threejs_production-mode_10x_persistent-hot + rss memory 811 MiB ± 46.3 MiB 804 MiB ± 24.2 MiB -0.89 %

@ahabhgk ahabhgk merged commit a6726b8 into main Feb 20, 2025
47 checks passed
@ahabhgk ahabhgk deleted the async-exe-module-hoook branch February 20, 2025 11:45
@h-a-n-a h-a-n-a mentioned this pull request Feb 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JSerFeng JSerFeng JSerFeng approved these changes

@hardfist hardfist Awaiting requested review from hardfist

Assignees

No one assigned

Labels

release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ahabhgk @JSerFeng