Skip to content

fix(type): Change the module in the LazyCompilationOptions from any to Module#9387

Merged
chenjiahan merged 2 commits intoweb-infra-dev:mainfrom
gaoachao:fix/lazyCompilationOptions-module-type
Feb 20, 2025
Merged

fix(type): Change the module in the LazyCompilationOptions from any to Module#9387
chenjiahan merged 2 commits intoweb-infra-dev:mainfrom
gaoachao:fix/lazyCompilationOptions-module-type

Conversation

@gaoachao
Copy link
Contributor

@gaoachao gaoachao commented Feb 19, 2025 •
edited
Loading

Change the module in the LazyCompilationOptions from any to Module.

export type LazyCompilationOptions = {
    // other properties
    test?: RegExp | ((module: Module) => boolean);
};

Documentation has been updated:

Summary

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link

netlify bot commented Feb 19, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 3176b3e
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67b6d3f021cfb7000848ca7f

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Feb 19, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 19, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9387 will not alter performance

Comparing gaoachao:fix/lazyCompilationOptions-module-type (3176b3e) with main (6aac9c2)

Summary

✅ 7 untouched benchmarks

@inottn
Copy link
Collaborator

inottn commented Feb 19, 2025

Good. Next up, let's update the API snapshot. You can run pnpm build:cli:dev && pnpm api-extractor:local to do that.

@gaoachao
Copy link
Contributor Author

gaoachao commented Feb 20, 2025 •
edited
Loading

Good. Next up, let's update the API snapshot. You can run pnpm build:cli:dev && pnpm api-extractor:local to do that.

@inottn I finish it. PTAL. 3176b3e

chenjiahan
chenjiahan approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@chenjiahan chenjiahan merged commit b46f13c into web-infra-dev:main Feb 20, 2025
27 checks passed
@gaoachao gaoachao deleted the fix/lazyCompilationOptions-module-type branch February 20, 2025 09:30
@h-a-n-a h-a-n-a mentioned this pull request Feb 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

Assignees

No one assigned

Labels

release: bug fix release: bug related release(mr only)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gaoachao @inottn @chenjiahan