Skip to content

fix: clear module_execution_results every compilation#9346

Merged
JSerFeng merged 1 commit intomainfrom
fix/rm-mem-leak
Feb 18, 2025
Merged

fix: clear module_execution_results every compilation#9346
JSerFeng merged 1 commit intomainfrom
fix/rm-mem-leak

Conversation

@JSerFeng
Copy link
Copy Markdown
Contributor

@JSerFeng JSerFeng commented Feb 17, 2025

Summary

Remove execution results cache when there is a new compilation to avoid mem leak

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: bug fix release: bug related release(mr only) labels Feb 17, 2025
@netlify
Copy link
Copy Markdown

netlify bot commented Feb 17, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 2797260
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67b320a025f78000086a3728

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Feb 17, 2025

CodSpeed Performance Report

Merging #9346 will create unknown performance changes

Comparing fix/rm-mem-leak (2797260) with main (fd5c313)

Summary

🆕 6 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 basic N/A 2.6 ms N/A
🆕 basic_sourcemap N/A 2.8 ms N/A
🆕 build_chunk_graph N/A 93 ms N/A
🆕 build_chunk_graph_parallel N/A 71.7 ms N/A
🆕 Traverse module graph by connections N/A 363 µs N/A
🆕 Traverse module graph by dependencies N/A 1.5 ms N/A

@JSerFeng JSerFeng marked this pull request as ready for review February 18, 2025 08:16
@JSerFeng JSerFeng merged commit 607f433 into main Feb 18, 2025
36 checks passed
@JSerFeng JSerFeng deleted the fix/rm-mem-leak branch February 18, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants