Skip to content

chore: simplify ci workflow#9283

Merged
hardfist merged 1 commit intomainfrom
yj/simplify-ci-workflow
Feb 13, 2025
Merged

chore: simplify ci workflow#9283
hardfist merged 1 commit intomainfrom
yj/simplify-ci-workflow

Conversation

@hardfist
Copy link
Copy Markdown
Contributor

@hardfist hardfist commented Feb 13, 2025

Summary

current build workflow is kind of too complex to maintain, remove unnecessary conditions(like native) to simplify workflow

  • remove native condition: it's used to diff self-hosted runner and github runner since self-hosted not run in isolated environment, after it migrate to k8s there's no need to use docker to do isolate( and we all run in github runner now actually)
  • explicitly tell difference between docker build and native build
    • run in docker if we don't have related github runner machine
    • run in native if we have related github runner machine

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Feb 13, 2025
@netlify
Copy link
Copy Markdown

netlify bot commented Feb 13, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit dc0ca95
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67adbf4a67910d00083447d5

@hardfist hardfist force-pushed the yj/simplify-ci-workflow branch 3 times, most recently from e5beddc to 7a50abb Compare February 13, 2025 09:42
@hardfist hardfist force-pushed the yj/simplify-ci-workflow branch from 7a50abb to dc0ca95 Compare February 13, 2025 09:45
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Feb 13, 2025

CodSpeed Performance Report

Merging #9283 will not alter performance

Comparing yj/simplify-ci-workflow (dc0ca95) with main (dab39ec)

🎉 Hooray! codspeed-rust just leveled up to 2.7.2!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 6 untouched benchmarks

@hardfist hardfist enabled auto-merge (squash) February 13, 2025 10:13
@hardfist hardfist merged commit 05524cd into main Feb 13, 2025
33 checks passed
@hardfist hardfist deleted the yj/simplify-ci-workflow branch February 13, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants