Skip to content

fix: incremental make rebuild removed entry module#9209

Merged
jerrykingxyz merged 3 commits intomainfrom
jerry/fix_make
Feb 9, 2025
Merged

fix: incremental make rebuild removed entry module#9209
jerrykingxyz merged 3 commits intomainfrom
jerry/fix_make

Conversation

@jerrykingxyz
Copy link
Copy Markdown
Contributor

@jerrykingxyz jerrykingxyz commented Feb 8, 2025 •
edited
Loading

Summary

  1. rename revoke_connection to revoke_dependencies and force remove will work even if connection does not exist.
impl ModuleGraph {
-  revoke_connection(&mut self, dep_id: &DependenciesId, force: bool) -> Option<BuildDependency>
+  revoke_dependency(&mut self, dep_id: &DependenciesId, force: bool) -> Option<BuildDependency>
}
  1. only return available force_build_dependencies when calling cutout.cutout_artifact.
struct Cutout {
  pub fn cutout_artifact(...) {
    ..
    force_build_deps
      .into_iter()
      .filter(...)
      .collect()
  }
}
  1. remove entry_dependency if the entry_dependency target module depends on files has been deleted.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack. labels Feb 8, 2025
@netlify
Copy link
Copy Markdown

netlify bot commented Feb 8, 2025 •
edited
Loading

✅ Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 3219f90
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67a767e34cc5860008cce8d8
😎 Deploy Preview https://deploy-preview-9209--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ahabhgk
ahabhgk previously approved these changes Feb 8, 2025
View reviewed changes
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Feb 8, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9209 will not alter performance

Comparing jerry/fix_make (3219f90) with main (abe222b)

🎉 Hooray! codspeed-rust just leveled up to 2.7.2!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 6 untouched benchmarks

@jerrykingxyz jerrykingxyz changed the title perf: clean isolated module when make finish fix: incremental make rebuild removed entry module Feb 8, 2025
@github-actions github-actions bot added release: bug fix release: bug related release(mr only) and removed release: performance release: performance related release(mr only) labels Feb 8, 2025
@jerrykingxyz jerrykingxyz requested a review from ahabhgk February 8, 2025 14:46
@jerrykingxyz jerrykingxyz enabled auto-merge (squash) February 8, 2025 14:46
@jerrykingxyz jerrykingxyz merged commit 09af1d8 into main Feb 9, 2025
36 checks passed
@jerrykingxyz jerrykingxyz deleted the jerry/fix_make branch February 9, 2025 12:59
@jerrykingxyz jerrykingxyz linked an issue Feb 17, 2025 that may be closed by this pull request
[Bug]: Persistent cache cause panic when running Rsbuild E2E cases #9205
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahabhgk ahabhgk ahabhgk approved these changes

Assignees

No one assigned

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Persistent cache cause panic when running Rsbuild E2E cases

2 participants

@jerrykingxyz @ahabhgk