feat(incremental): side effects optimization#8799
Merged
JSerFeng merged 5 commits intoweb-infra-dev:mainfrom Dec 25, 2024
Merged
feat(incremental): side effects optimization#8799JSerFeng merged 5 commits intoweb-infra-dev:mainfrom
JSerFeng merged 5 commits intoweb-infra-dev:mainfrom
Conversation
✅ Deploy Preview for rspack canceled.
|
c66ba5a to
436feb3
Compare
64d5877 to
456b6d5
Compare
CodSpeed Performance ReportMerging #8799 will not alter performanceComparing Summary
|
JSerFeng
approved these changes
Dec 25, 2024
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Incremental side effects optimization
Actually in most cases the improvement of incremental side effects is always not good enough as expected, only improve a little bit, in an internal project (FS): start cost ~63ms and rebuild cost ~44ms for this phase, this is because this only incrementally
find optimizable connections, but we didn't/can't implement incremental fordo optimize connectionsandfind new optimizable connections based on the optimized connections.Checklist