fix(lightningcss): align type with lightningcss#8456
Merged
chenjiahan merged 1 commit intomainfrom Nov 18, 2024
Merged
Conversation
✅ Deploy Preview for rspack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
2 tasks
chenjiahan
reviewed
Nov 18, 2024
chenjiahan
reviewed
Nov 18, 2024
Member
chenjiahan
left a comment
There was a problem hiding this comment.
Can you add the co-author information?
Example: nuxt/nuxt#29142
Co-authored-by: zackarychapple <zack_chapple@ultimatesoftware.com>
3afdbd2 to
182da9d
Compare
chenjiahan
approved these changes
Nov 18, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In lightningcss, the draft syntax options is drafts.
We should align the type with lightningcss, while have not break change. So we maintain
options.draftandoptions.drafts, then we use drafts firstly if user provide both drafts and draft options.It's the product of another hand, This PR from @zackarychapple
Checklist