fix(lightning css): align type with lightning documentation#8197
Closed
zackarychapple wants to merge 1 commit intoweb-infra-dev:mainfrom
Closed
fix(lightning css): align type with lightning documentation#8197zackarychapple wants to merge 1 commit intoweb-infra-dev:mainfrom
zackarychapple wants to merge 1 commit intoweb-infra-dev:mainfrom
Conversation
✅ Deploy Preview for rspack canceled.
|
Contributor
|
even it's a typo, this change is still a breaking change, we can try to be compatible by supporting both |
Member
|
@GiveMe-A-Name can you take this? |
Member
|
CI failed, you should run
And like hardfist Said, we can support both |
2 tasks
Member
|
This PR have long time have not progress, I fix it in another PR #8456 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In the lightning css documentation there is a option to enable drafts. This option was incorrectly named as
draftinstead ofdrafts. Updated the typing to the proper name as per the documentation.Checklist