Skip to content

feat: support analysing AMD module format#8389

Merged
ahabhgk merged 24 commits intoweb-infra-dev:mainfrom
nilptr:nilptr/feat/amd-define
Nov 27, 2024
Merged

feat: support analysing AMD module format#8389
ahabhgk merged 24 commits intoweb-infra-dev:mainfrom
nilptr:nilptr/feat/amd-define

Conversation

@nilptr
Copy link
Copy Markdown
Contributor

@nilptr nilptr commented Nov 10, 2024 •
edited
Loading

Summary

resolve #4313, support analysing AMD module format (context is not supported yet)

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link
Copy Markdown

netlify bot commented Nov 10, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit e769a2c
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6745f41bcb8a5b00084cb310

@nilptr nilptr changed the title Draft: support amd modules Draft: support amd modules #4313 Nov 10, 2024
@nilptr nilptr changed the title Draft: support amd modules #4313 Draft: support amd modules Nov 10, 2024
@nilptr nilptr marked this pull request as draft November 10, 2024 16:31
@nilptr nilptr force-pushed the nilptr/feat/amd-define branch 3 times, most recently from 0ef0151 to 8ee4382 Compare November 24, 2024 11:30
@nilptr nilptr changed the title Draft: support amd modules support analyze AMD module format Nov 24, 2024
@nilptr nilptr changed the title support analyze AMD module format feat: support analysing AMD module format Nov 24, 2024
@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Nov 24, 2024
nilptr added 20 commits November 24, 2024 23:19
@nilptr
feat(amd): add amd runtime globals, dep category, and dep type
d39db15
@nilptr
feat(amd): add amd deps
7eea7a8
@nilptr
feat(amd): add amd_define_dependency_parser_plugin and require_js_stu…
797b1f7 
…ff_plugin
@nilptr
feat(amd): set AmdRequireItem dep factory
046f3cc
@nilptr
fix(amd): json_stringify named_module
260a409
@nilptr
chore: save tests
5f3c1f5
@nilptr
fix(amd): flag local module used when it's actually used
0fee5a3
@nilptr
feat(amd): add amd_require_dependencies_block_parser_plugin
823bf30
@nilptr
chore: save amd require tests
1105bf1
@nilptr
chore: save amd require tests
f93209d
@nilptr
feat(amd): add unsupported dependency
e1c9916
@nilptr
feat(amd): add amd option
aee8f9c
@nilptr
feat(amd): add amd runtime modules
7de7fde
@nilptr
feat(amd): use amd plugins
c8c18b9
@nilptr
feat(amd): move amd test cases under config
49ed652
@nilptr
feat(amd): add AMDPlugin requirejs-related logic to RequireJsStuffPlugin
b42223e
@nilptr
chore(amd): update test cases
35db167
@nilptr
feat(amd): add real amd libs as amd test cases
6a3f350
@nilptr
refactor(amd_define_dependency): use format macro named parameters to…
1505d7a 
… improve readability
@nilptr
fix(amd ci): update jest snapshot
a434965
@nilptr nilptr force-pushed the nilptr/feat/amd-define branch from 9508987 to 109ce4c Compare November 24, 2024 15:19
@nilptr nilptr marked this pull request as ready for review November 24, 2024 15:22
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Nov 24, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #8389 will not alter performance

Comparing nilptr:nilptr/feat/amd-define (e769a2c) with main (c1e8f11)

Summary

✅ 1 untouched benchmarks

@nilptr
Copy link
Copy Markdown
Contributor Author

nilptr commented Nov 25, 2024

hi @GiveMe-A-Name @ahabhgk this PR is ready to review. Please help take a look. Thanks.

@GiveMe-A-Name GiveMe-A-Name requested review from GiveMe-A-Name and ahabhgk and removed request for ahabhgk November 25, 2024 02:40
ahabhgk
ahabhgk reviewed Nov 25, 2024
View reviewed changes
@ahabhgk
Copy link
Copy Markdown
Contributor

ahabhgk commented Nov 26, 2024

CI should pass

@nilptr nilptr force-pushed the nilptr/feat/amd-define branch from 016d73e to e769a2c Compare November 26, 2024 16:15
@nilptr
Copy link
Copy Markdown
Contributor Author

nilptr commented Nov 27, 2024

CI should pass

fixed

@inottn inottn mentioned this pull request Nov 27, 2024
Closed
ahabhgk
ahabhgk approved these changes Nov 27, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@ahabhgk ahabhgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks!

@ahabhgk ahabhgk merged commit 96f500d into web-infra-dev:main Nov 27, 2024
@nilptr nilptr deleted the nilptr/feat/amd-define branch December 7, 2024 13:41
@nilptr nilptr restored the nilptr/feat/amd-define branch December 7, 2024 13:42
@nanianlisao
Copy link
Copy Markdown
Contributor

nanianlisao commented Jan 10, 2025

That is great!

It might be wise to consider ensuring consistency with Webpack as well.

rspack/packages/rspack/src/config/normalization.ts

Lines 373 to 376 in 46d0566

devServer: config.devServer,
profile: config.profile,
amd: config.amd ? JSON.stringify(config.amd) : undefined,
bail: config.bail

https://github.com/webpack/webpack/blob/3919c844eca394d73ca930e4fc5506fb86e2b094/lib/WebpackOptionsApply.js#L389-L395

By the way, the content regarding this configuration has not yet been updated on the official website.

@chenjiahan

@chenjiahan
Copy link
Copy Markdown
Member

chenjiahan commented Jan 10, 2025

Thank you for your feedback! Can you file an issue to track this?

@nanianlisao nanianlisao mentioned this pull request Jan 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahabhgk ahabhgk ahabhgk approved these changes

@GiveMe-A-Name GiveMe-A-Name Awaiting requested review from GiveMe-A-Name

Assignees

No one assigned

Labels

release: feature release: feature related release(mr only)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

support analyze AMD module format

4 participants

@nilptr @ahabhgk @nanianlisao @chenjiahan