Skip to content

fix: tapable run in wrong closure#8376

Merged
SyMind merged 5 commits intomainfrom
fix-tapable
Nov 8, 2024
Merged

fix: tapable run in wrong closure#8376
SyMind merged 5 commits intomainfrom
fix-tapable

Conversation

@SyMind
Copy link
Copy Markdown
Member

@SyMind SyMind commented Nov 8, 2024 •
edited
Loading

Summary

Relative: facebook/docusaurus#10648

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Nov 8, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Nov 8, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 9269f9e
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/672dcb937f74c600081b1d53

@SyMind SyMind marked this pull request as ready for review November 8, 2024 08:23
ahabhgk
ahabhgk previously approved these changes Nov 8, 2024
View reviewed changes
@SyMind SyMind merged commit 75f9573 into main Nov 8, 2024
@SyMind SyMind deleted the fix-tapable branch November 8, 2024 08:40
JSerFeng added a commit that referenced this pull request Nov 18, 2024
@JSerFeng
Revert "fix: tapable run in wrong closure (#8376)"
65a6aba 
This reverts commit 75f9573.
@JSerFeng JSerFeng mentioned this pull request Nov 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahabhgk ahabhgk ahabhgk approved these changes

Assignees

@SyMind SyMind

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SyMind @ahabhgk