feat: support experimental loader emitDiagnostic#7879
Merged
Conversation
✅ Deploy Preview for rspack canceled.
|
941ddbd to
2b937fe
Compare
a4fd487 to
eecf87b
Compare
25d572c to
6c24a15
Compare
hardfist
reviewed
Sep 19, 2024
hardfist
reviewed
Sep 19, 2024
...spack-test-tools/tests/diagnosticsCases/module-build-failed/loader-emit-diagnostic/stats.err
Show resolved
Hide resolved
hardfist
reviewed
Sep 19, 2024
Contributor
|
LGTM, waiting for @colinaaa's feedback on this |
Collaborator
hardfist
approved these changes
Sep 19, 2024
JSerFeng
pushed a commit
that referenced
this pull request
Sep 29, 2024
* feat: init * test: add * test: add * chore: cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes #5913
Supported experimental loader API
emitDiagnostic.This works almost the same as
emitErrororemitWarning. But, it's for emitting rich-formatted diagnostics.Example
For loader:
it outputs:
Note: This is an experimental API and is rspack-specific.
Checklist