fix: avoid import external module re-assigin in concatenation#7839
Merged
fi3ework merged 2 commits intoweb-infra-dev:mainfrom Sep 18, 2024
Merged
fix: avoid import external module re-assigin in concatenation#7839fi3ework merged 2 commits intoweb-infra-dev:mainfrom
fi3ework merged 2 commits intoweb-infra-dev:mainfrom
Conversation
✅ Deploy Preview for rspack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
b0c3b18 to
0182d0d
Compare
c4d856b to
7eeb9cc
Compare
LingyuCoder
approved these changes
Sep 18, 2024
42 tasks
JSerFeng
pushed a commit
that referenced
this pull request
Sep 29, 2024
* fix: avoid import external module re-assigin in concatenation * test: add test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR will simplify
"module"external type's runtime like below. When building a package with Rspack, it can be ensured that external modules can be tree shaken.Changes summary:
"module"external type.MultiTaskProcessorcould handle function config.Checklist