Conversation
✅ Deploy Preview for rspack canceled.
|
70bc82f to
a5fdca5
Compare
ahabhgk
approved these changes
Sep 6, 2024
shulaoda
pushed a commit
to shulaoda/rspack
that referenced
this pull request
Sep 9, 2024
* fix: remove HotUpdateChunk in chunks
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In webpack, there is no need to add
HotUpdateChunktocompilation.chunks, becauseHotUpdateChunkis no longer used after generating the manifest.However, in Rspack, we need to add
HotUpdateChunktocompilation.chunk_by_ukeybecause during the manifest generation,HotUpdateChunkis passed to various plugins via theukey. The plugins then use theukeyto querycompilation.chunk_by_ukeyto get theHotUpdateChunkinstance.Therefore, in Rspack, after the manifest is generated, we need to manually remove the
HotUpdateChunkfromcompilation.chunks.In webpack,
compilation.chunkGraphuses aWeakMapto maintain the relationship betweenChunks andModules.This means the lifecycle of these data is tied to the
Chunk, and they are garbage-collected when theChunkis.In Rspack, we need to manually clean up the data in
compilation.chunk_graphafterHotUpdateChunkis used.Checklist