fix(make): isolated module clean incomplete#7761
Merged
jerrykingxyz merged 2 commits intomainfrom Sep 4, 2024
Merged
Conversation
✅ Deploy Preview for rspack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
|
may fix #7419 can you release a canary ? |
Contributor
Author
Contributor
|
Can we add a test, for example using a plugin hook to print all modules after rebuild ? |
Contributor
Author
Good Idea, i will add it |
JSerFeng
approved these changes
Sep 4, 2024
hardfist
pushed a commit
that referenced
this pull request
Sep 4, 2024
* fix(make): isolated module clean incomplete * test: add make clean_isolated_module test case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the step of clean isolated module in
cutoutwill only clean one layer module.There are a example:
a->b->caso that it does not depend on modulebBefore this PR the module_graph will only remove module
b, because of callrevoke_modulesafter module isolated check.Checklist