Skip to content

chore: bump swc_core from 56 to 58#13164

Merged
CPunisher merged 4 commits intomainfrom
03-02-chore/bump-swc
Mar 2, 2026
Merged

chore: bump swc_core from 56 to 58#13164
CPunisher merged 4 commits intomainfrom
03-02-chore/bump-swc

Conversation

@CPunisher
Copy link
Copy Markdown
Contributor

@CPunisher CPunisher commented Mar 2, 2026

Summary

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings March 2, 2026 05:36
@CPunisher CPunisher requested a review from quininer as a code owner March 2, 2026 05:36
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Mar 2, 2026
Copilot AI reviewed Mar 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the workspace’s SWC (and related SWC ecosystem) dependencies to newer versions and adjusts internal integration points so Rspack continues to parse/transform code correctly and tests reflect the new output.

Changes:

  • Bump swc_core to 58.0.3 and align related swc* crates plus swc_experimental_* to 0.6.0.
  • Update ConcatenatedModule’s swc_experimental parsing flow to match the new parser/AST APIs (explicit Ast, StringAllocator, updated Parser::new_from/Lexer::new wiring).
  • Refresh stats API test expectations (hash/output text) to match new SWC-generated results.

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Cargo.toml Bumps SWC family and swc_experimental_* versions in workspace deps.
Cargo.lock Lockfile refresh reflecting new SWC versions and transitive dependency graph updates.
crates/rspack_workspace/src/generated.rs Updates the generated SWC core version string exposed by the workspace.
crates/rspack_core/src/concatenated_module.rs Adapts concatenation parsing/semantic analysis to updated swc_experimental APIs.
tests/rspack-test/statsAPICases/basic.js Updates expected stats hash/output string after SWC bump.
tests/rspack-test/statsAPICases/exports.js Updates expected stats hashes after SWC bump.
tests/rspack-test/statsAPICases/ids.js Updates expected stats hash after SWC bump.
tests/rspack-test/statsAPICases/with-query.js Updates expected stats hashes after SWC bump.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 2, 2026

📦 Binary Size-limit

Comparing 7d9cc1f to feat: support preserve-unknown to keep unknown import.meta properties (#12796) by intellild

🎉 Size decreased by 14.88KB from 48.90MB to 48.89MB (⬇️0.03%)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 2, 2026

Rsdoctor Bundle Diff Analysis

⚠️ Note: The latest commit (7ded4f0a33) does not have baseline artifacts. Using commit 27c8fbf409 for baseline comparison instead. If this seems incorrect, please wait a few minutes and try rerunning the workflow.

Found 5 projects in monorepo, 4 projects with changes.

📊 Quick Summary
Project Total Size Change
react-10k 5.7 MB -2.0 B (-0.0%)
react-1k 826.2 KB -2.0 B (-0.0%)
react-5k 2.7 MB -2.0 B (-0.0%)
rome 984.2 KB 0
ui-components 2.3 MB -12.0 B (-0.0%)
📋 Detailed Reports (Click to expand)

📁 react-10k

Path: ../build-tools-performance/cases/react-10k/dist/rsdoctor-data.json

📌 Baseline Commit: 27c8fbf409 | PR: #12796

Metric Current Baseline Change
📊 Total Size 5.7 MB 5.7 MB -2.0 B (-0.0%)
📄 JavaScript 5.7 MB 5.7 MB -2.0 B (-0.0%)
🎨 CSS 21.0 B 21.0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: react-10k Bundle Diff

📁 react-1k

Path: ../build-tools-performance/cases/react-1k/dist/rsdoctor-data.json

📌 Baseline Commit: 27c8fbf409 | PR: #12796

Metric Current Baseline Change
📊 Total Size 826.2 KB 826.2 KB -2.0 B (-0.0%)
📄 JavaScript 826.2 KB 826.2 KB -2.0 B (-0.0%)
🎨 CSS 0 B 0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: react-1k Bundle Diff

📁 react-5k

Path: ../build-tools-performance/cases/react-5k/dist/rsdoctor-data.json

📌 Baseline Commit: 27c8fbf409 | PR: #12796

Metric Current Baseline Change
📊 Total Size 2.7 MB 2.7 MB -2.0 B (-0.0%)
📄 JavaScript 2.7 MB 2.7 MB -2.0 B (-0.0%)
🎨 CSS 21.0 B 21.0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: react-5k Bundle Diff

📁 ui-components

Path: ../build-tools-performance/cases/ui-components/dist/rsdoctor-data.json

📌 Baseline Commit: 27c8fbf409 | PR: #12796

Metric Current Baseline Change
📊 Total Size 2.3 MB 2.3 MB -12.0 B (-0.0%)
📄 JavaScript 2.0 MB 2.0 MB -12.0 B (-0.0%)
🎨 CSS 271.4 KB 271.4 KB 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: ui-components Bundle Diff

Generated by Rsdoctor GitHub Action

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 2, 2026

Merging this PR will not alter performance

✅ 16 untouched benchmarks
⏩ 3 skipped benchmarks1

Comparing 03-02-chore/bump-swc (7d9cc1f) with main (27c8fbf)2

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (95a5512) during the generation of this report, so 27c8fbf was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@CPunisher CPunisher merged commit e675fe7 into main Mar 2, 2026
56 checks passed
@CPunisher CPunisher deleted the 03-02-chore/bump-swc branch March 2, 2026 06:31
LingyuCoder pushed a commit that referenced this pull request Mar 2, 2026
@CPunisher @LingyuCoder
chore: bump swc_core from 56 to 58 (#13164)
0206981 
* chore: bump swc_core and swc_exp

* fix: parser api breaking

* chore: update snapshots

* refactor: use get_atom
@CPunisher CPunisher mentioned this pull request Mar 2, 2026
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@quininer quininer quininer approved these changes

Assignees

No one assigned

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CPunisher @quininer