Skip to content

feat!: use "rspack" as default trustedTypes policy name#12799

Merged
chenjiahan merged 2 commits intov2from
feat/use-rspack-as-default-trusted-types-policy-name
Jan 21, 2026
Merged

feat!: use "rspack" as default trustedTypes policy name#12799
chenjiahan merged 2 commits intov2from
feat/use-rspack-as-default-trusted-types-policy-name

Conversation

@LingyuCoder
Copy link
Copy Markdown
Contributor

Summary

Change the default value of output.trustedTypes.policyName from "webpack" to "rspack" to better reflect the bundler being used.

When using Trusted Types with Rspack, the default policy name should be "rspack" instead of "webpack" for consistency and clarity.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Change the default value of `output.trustedTypes.policyName` from
"webpack" to "rspack" to better reflect the bundler being used.
@LingyuCoder LingyuCoder requested a review from hardfist as a code owner January 21, 2026 03:58
@netlify
Copy link
Copy Markdown

netlify bot commented Jan 21, 2026

Deploy Preview for rspack-v2 ready!

Name Link
🔨 Latest commit 14402a1
🔍 Latest deploy log https://app.netlify.com/projects/rspack-v2/deploys/69705555fc441c0008cc6759
😎 Deploy Preview https://deploy-preview-12799--rspack-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: feature release: feature related release(mr only) labels Jan 21, 2026
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Jan 21, 2026

Deploying rspack-v2 with  Cloudflare Pages  Cloudflare Pages

Latest commit: 14402a1
Status: ✅  Deploy successful!
Preview URL: https://2b6c29ec.rspack-v2.pages.dev
Branch Preview URL: https://feat-use-rspack-as-default-t.rspack-v2.pages.dev

View logs

@LingyuCoder LingyuCoder changed the title feat(output): use "rspack" as default trustedTypes policy name feat!: use "rspack" as default trustedTypes policy name Jan 21, 2026
@LingyuCoder LingyuCoder added the release: breaking change release: breaking change related release(mr only) label Jan 21, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 21, 2026

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 5 projects with changes.

📊 Quick Summary
Project Total Size Change
react-10k 5.7 MB -71.0 B (-0.0%)
react-1k 825.3 KB -41.0 B (-0.0%)
react-5k 2.7 MB -60.0 B (-0.0%)
rome 985.8 KB +1.7 KB (0.2%)
ui-components 2.1 MB -30.0 B (-0.0%)
📋 Detailed Reports (Click to expand)

📁 react-10k

Path: ../build-tools-performance/cases/react-10k/dist/rsdoctor-data.json

📌 Baseline Commit: 48885c75c9 | PR: #12773

Metric Current Baseline Change
📊 Total Size 5.7 MB 5.7 MB -71.0 B (-0.0%)
📄 JavaScript 5.7 MB 5.7 MB -71.0 B (-0.0%)
🎨 CSS 21.0 B 21.0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: react-10k Bundle Diff

📁 react-1k

Path: ../build-tools-performance/cases/react-1k/dist/rsdoctor-data.json

📌 Baseline Commit: 48885c75c9 | PR: #12773

Metric Current Baseline Change
📊 Total Size 825.3 KB 825.4 KB -41.0 B (-0.0%)
📄 JavaScript 825.3 KB 825.4 KB -41.0 B (-0.0%)
🎨 CSS 0 B 0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: react-1k Bundle Diff

📁 react-5k

Path: ../build-tools-performance/cases/react-5k/dist/rsdoctor-data.json

📌 Baseline Commit: 48885c75c9 | PR: #12773

Metric Current Baseline Change
📊 Total Size 2.7 MB 2.7 MB -60.0 B (-0.0%)
📄 JavaScript 2.7 MB 2.7 MB -60.0 B (-0.0%)
🎨 CSS 21.0 B 21.0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: react-5k Bundle Diff

📁 rome

Path: ../build-tools-performance/cases/rome/dist/rsdoctor-data.json

📌 Baseline Commit: 48885c75c9 | PR: #12773

Metric Current Baseline Change
📊 Total Size 985.8 KB 984.2 KB +1.7 KB (0.2%)
📄 JavaScript 985.8 KB 984.2 KB +1.7 KB (0.2%)
🎨 CSS 0 B 0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: rome Bundle Diff

📁 ui-components

Path: ../build-tools-performance/cases/ui-components/dist/rsdoctor-data.json

📌 Baseline Commit: 48885c75c9 | PR: #12773

Metric Current Baseline Change
📊 Total Size 2.1 MB 2.1 MB -30.0 B (-0.0%)
📄 JavaScript 2.0 MB 2.0 MB -30.0 B (-0.0%)
🎨 CSS 83.0 KB 83.0 KB 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: ui-components Bundle Diff

Generated by Rsdoctor GitHub Action

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 21, 2026

📦 Binary Size-limit

Comparing 14402a1 to fix: require.resolve() replaced as require() (#12773) by intellild

🎉 Size decreased by 318.50KB from 47.99MB to 47.68MB (⬇️0.65%)

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Jan 21, 2026

Merging this PR will not alter performance

✅ 16 untouched benchmarks
⏩ 1 skipped benchmark1


Comparing feat/use-rspack-as-default-trusted-types-policy-name (14402a1) with v2 (6dc458e)

Open in CodSpeed

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports.

@chenjiahan chenjiahan merged commit a1ae899 into v2 Jan 21, 2026
54 checks passed
@chenjiahan chenjiahan deleted the feat/use-rspack-as-default-trusted-types-policy-name branch January 21, 2026 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: breaking change release: breaking change related release(mr only) release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants