fix: require.resolve() replaced as require()#12773
Merged
LingyuCoder merged 9 commits intoweb-infra-dev:mainfrom Jan 21, 2026
Merged
fix: require.resolve() replaced as require()#12773LingyuCoder merged 9 commits intoweb-infra-dev:mainfrom
require.resolve() replaced as require()#12773LingyuCoder merged 9 commits intoweb-infra-dev:mainfrom
Conversation
✅ Deploy Preview for rspack canceled.Built without sensitive environment variables
|
require.resolve() replaced as require()
require.resolve() replaced as require()require.resolve() replaced as require()
Merging this PR will not alter performance
Comparing 
Footnotes
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where require.resolve() and require.resolveWeak() were incorrectly being replaced as require() calls, and prevents transpilation when require is a local variable rather than the global CommonJS require.
Changes:
- Fixed identifier evaluation for
require.resolveandrequire.resolveWeakto preserve correct identifier names - Added
should_process_resolve()check to detect whenrequireis a local variable and skip CommonJS transformation - Added test case to verify the fix works correctly
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
crates/rspack_plugin_javascript/src/parser_plugin/common_js_imports_parse_plugin.rs |
Fixed bug where require.resolve and require.resolveWeak were incorrectly evaluated with root_info as "require" instead of their actual names; added should_process_resolve() to check if require is a local variable; integrated check into resolve handlers |
tests/rspack-test/normalCases/require/issue-10479/require.js |
Creates a local require variable using createRequire to test the fix |
tests/rspack-test/normalCases/require/issue-10479/index.js |
Verifies that require.resolve() is not transformed when require is a local variable |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
LGTM, thanks |
LingyuCoder
approved these changes
Jan 21, 2026
Member
|
Thank you! |
This was referenced Jan 21, 2026
LingyuCoder
pushed a commit
that referenced
this pull request
Jan 21, 2026
* fix issue 10479 * fix issue 10479 * fix issue 10479 * revert incorrect changes * fix `require.resolve()`` replaced as `require()` * check if `require` is a local variable * fix test * fix test
chenjiahan
pushed a commit
that referenced
this pull request
Jan 21, 2026
* fix issue 10479 * fix issue 10479 * fix issue 10479 * revert incorrect changes * fix `require.resolve()`` replaced as `require()` * check if `require` is a local variable * fix test * fix test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*
require.resolve()andrequire.resolveWeakshould not be replaced asrequire()requireis a local variable, should not be transpiled as commonjs importRelated links
#10479
Checklist