Skip to content

feat!: enable verbatimModuleSyntax of builtin:swc-loader by default#12668

Merged
LingyuCoder merged 2 commits intov2from
feat/enable-verbatim-module-sytax-default
Jan 8, 2026
Merged

feat!: enable verbatimModuleSyntax of builtin:swc-loader by default#12668
LingyuCoder merged 2 commits intov2from
feat/enable-verbatim-module-sytax-default

Conversation

@LingyuCoder
Copy link
Copy Markdown
Contributor

@LingyuCoder LingyuCoder commented Jan 8, 2026

Summary

verbatimModuleSyntax is a TypeScript compiler option that:

  • Requires explicit type modifier for type-only imports/exports
  • Ensures type-only imports are completely erased at runtime
  • Provides better compatibility with ES modules and modern bundlers

see https://www.typescriptlang.org/tsconfig/#verbatimModuleSyntax for more detail

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Jan 8, 2026
@LingyuCoder LingyuCoder changed the title feat: enable verbatimModuleSyntax of builtin:swc-loader by default feat!: enable verbatimModuleSyntax of builtin:swc-loader by default Jan 8, 2026
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Jan 8, 2026
@LingyuCoder LingyuCoder added release: breaking change release: breaking change related release(mr only) and removed team The issue/pr is created by the member of Rspack. labels Jan 8, 2026
@netlify
Copy link
Copy Markdown

netlify bot commented Jan 8, 2026 •
edited
Loading

✅ Deploy Preview for rspack-v2 ready!

Name Link
🔨 Latest commit 3d1ee69
🔍 Latest deploy log https://app.netlify.com/projects/rspack-v2/deploys/695f2ea649d5ff0008263841
😎 Deploy Preview https://deploy-preview-12668--rspack-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 8, 2026

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 3 projects with changes.

📊 Quick Summary
Project Total Size Change
react-10k 5.7 MB -8.0 B (-0.0%)
react-1k 825.4 KB 0
react-5k 2.7 MB +1.0 B (0.0%)
rome 986.0 KB +1.7 KB (0.2%)
ui-components 2.1 MB 0
📋 Detailed Reports (Click to expand)

📁 react-10k

Path: ../build-tools-performance/cases/react-10k/dist/rsdoctor-data.json

📌 Baseline Commit: 4ecc5cb27e | PR: #12665

Metric Current Baseline Change
📊 Total Size 5.7 MB 5.7 MB -8.0 B (-0.0%)
📄 JavaScript 5.7 MB 5.7 MB -8.0 B (-0.0%)
🎨 CSS 21.0 B 21.0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: react-10k Bundle Diff

📁 react-5k

Path: ../build-tools-performance/cases/react-5k/dist/rsdoctor-data.json

📌 Baseline Commit: 4ecc5cb27e | PR: #12665

Metric Current Baseline Change
📊 Total Size 2.7 MB 2.7 MB +1.0 B (0.0%)
📄 JavaScript 2.7 MB 2.7 MB +1.0 B (0.0%)
🎨 CSS 21.0 B 21.0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: react-5k Bundle Diff

📁 rome

Path: ../build-tools-performance/cases/rome/dist/rsdoctor-data.json

📌 Baseline Commit: 4ecc5cb27e | PR: #12665

Metric Current Baseline Change
📊 Total Size 986.0 KB 984.3 KB +1.7 KB (0.2%)
📄 JavaScript 986.0 KB 984.3 KB +1.7 KB (0.2%)
🎨 CSS 0 B 0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: rome Bundle Diff

Generated by Rsdoctor GitHub Action

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 8, 2026

📦 Binary Size-limit

Comparing 3d1ee69 to fix(lint): enable @typescript-eslint/require-await rule (#12664) by Tu Shaokun

🎉 Size decreased by 30.75KB from 47.87MB to 47.84MB (⬇️0.06%)

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Jan 8, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing feat/enable-verbatim-module-sytax-default (3d1ee69) with main (4ecc5cb)1

Summary

✅ 16 untouched benchmarks
⏩ 1 skipped benchmark2

Footnotes

  1. No successful run was found on v2 (907c01d) during the generation of this report, so main (4ecc5cb) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

  2. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports. ↩

@LingyuCoder LingyuCoder merged commit b14769e into v2 Jan 8, 2026
83 of 85 checks passed
@LingyuCoder LingyuCoder deleted the feat/enable-verbatim-module-sytax-default branch January 8, 2026 05:34
@hardfist hardfist mentioned this pull request Jan 26, 2026
Closed
hardfist added a commit that referenced this pull request Jan 26, 2026
@hardfist
Revert "feat!: enable verbatimModuleSyntax of builtin:swc-loader …
f36aa57 
…by default (#12668)"

This reverts commit b14769e.
@hardfist hardfist mentioned this pull request Jan 26, 2026
Merged
2 tasks
hardfist added a commit that referenced this pull request Jan 26, 2026
@hardfist
feat!: revert enable verbatimModuleSyntax (#12846)
36b6f6f 
Revert "feat!: enable `verbatimModuleSyntax` of `builtin:swc-loader` by default (#12668)"

This reverts commit b14769e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hardfist hardfist hardfist approved these changes

@CPunisher CPunisher Awaiting requested review from CPunisher

Assignees

No one assigned

Labels

release: breaking change release: breaking change related release(mr only) release: feature release: feature related release(mr only)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LingyuCoder @hardfist