Skip to content

chore(workflow): run diff CI on push events#12346

Merged
chenjiahan merged 3 commits intomainfrom
chore/diff-ci
Dec 2, 2025
Merged

chore(workflow): run diff CI on push events#12346
chenjiahan merged 3 commits intomainfrom
chore/diff-ci

Conversation

@yifancong
Copy link
Copy Markdown
Contributor

@yifancong yifancong commented Dec 2, 2025 •
edited
Loading

Summary

chore: change the diff ci yaml

Workflow trigger improvements:

  • The CI workflow now also runs on push events to the main branch, in addition to pull request events (opened, synchronize, and reopened). This ensures that changes pushed directly to main are also checked by the workflow.
  • The workflow trigger for pull requests now uses reopened instead of closed, so the workflow is triggered when a pull request is reopened rather than when it is closed.

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@yifancong yifancong marked this pull request as ready for review December 2, 2025 05:01
@netlify
Copy link
Copy Markdown

netlify bot commented Dec 2, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit c18b698
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/692e85e565de98000832d6cf

Copilot AI reviewed Dec 2, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the CI diff workflow configuration to expand its trigger conditions and update a dependency. The changes enable the workflow to run on push events to the main branch (in addition to pull requests) and handle reopened PRs.

Key changes:

  • Modified pull request trigger types: added reopened, removed closed
  • Added push trigger for the main branch
  • Updated rsdoctor-action to a newer commit hash

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 2, 2025 •
edited
Loading

Rsdoctor Bundle Diff Analysis

Found 5 project(s) in monorepo.

📁 react-10k

Path: ../build-tools-performance/cases/react-10k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 5.7 MB - -
📄 JavaScript 5.7 MB - -
🎨 CSS 21.0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 react-1k

Path: ../build-tools-performance/cases/react-1k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 822.6 KB - -
📄 JavaScript 822.6 KB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 react-5k

Path: ../build-tools-performance/cases/react-5k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 2.7 MB - -
📄 JavaScript 2.7 MB - -
🎨 CSS 21.0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 rome

Path: ../build-tools-performance/cases/rome/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 984.3 KB - -
📄 JavaScript 984.3 KB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 ui-components

Path: ../build-tools-performance/cases/ui-components/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 2.1 MB - -
📄 JavaScript 2.0 MB - -
🎨 CSS 83.0 KB - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

Generated by Rsdoctor GitHub Action

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 2, 2025 •
edited
Loading

📦 Binary Size-limit

Comparing c18b698 to fix(diagnostic): dim gutter style for better visual hierarchy (#12341) by neverland

🙈 Size remains the same at 47.70MB

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Dec 2, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #12346 will not alter performance

Comparing chore/diff-ci (c18b698) with main (9723c1b)

Summary

✅ 17 untouched

chenjiahan
chenjiahan reviewed Dec 2, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some PR description?

@yifancong
Update .github/workflows/ci-diff.yml
c18b698 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@yifancong
Copy link
Copy Markdown
Contributor Author

yifancong commented Dec 2, 2025

Could you add some PR description?

@chenjiahan Done

@yifancong yifancong requested a review from chenjiahan December 2, 2025 06:54
@chenjiahan chenjiahan changed the title chore: change the diff ci yaml chore(workflow): run diff CI on push events Dec 2, 2025
@chenjiahan chenjiahan merged commit 8bcf8af into main Dec 2, 2025
53 checks passed
@chenjiahan chenjiahan deleted the chore/diff-ci branch December 2, 2025 07:09
This was referenced Dec 2, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@chenjiahan chenjiahan chenjiahan approved these changes

@stormslowly stormslowly Awaiting requested review from stormslowly stormslowly is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yifancong @chenjiahan