Skip to content

test: should wait until async startup chunk dependencies loaded#12234

Merged
LingyuCoder merged 1 commit intomainfrom
test/startup-chunk-dependencies
Nov 18, 2025
Merged

test: should wait until async startup chunk dependencies loaded#12234
LingyuCoder merged 1 commit intomainfrom
test/startup-chunk-dependencies

Conversation

@LingyuCoder
Copy link
Contributor

Summary

Should wait until async startup chunk dependencies loaded which should be splitted from entry chunks by bundle splitting.

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings November 18, 2025 10:15
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Nov 18, 2025
@netlify
Copy link

netlify bot commented Nov 18, 2025

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 960cec9
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/691c474605ac6a0008dcc9a4
😎 Deploy Preview https://deploy-preview-12234--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for waiting on async startup chunk dependencies in test execution. The test runner now tracks pending chunk loading operations via a WAITING array and ensures all chunks are loaded before returning test results.

  • Adds a WAITING array to track chunk loading promises
  • Intercepts webpack runtime startup chunk dependencies to defer execution
  • Waits for all pending chunk loads before completing test runs

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@LingyuCoder LingyuCoder enabled auto-merge (squash) November 18, 2025 10:25
@github-actions
Copy link
Contributor

📦 Binary Size-limit

Comparing 960cec9 to fix(types): use namespace imports for Node.js built-in modules (#12232) by Cong-Cong Pan

🙈 Size remains the same at 47.47MB

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 18, 2025

CodSpeed Performance Report

Merging #12234 will not alter performance

Comparing test/startup-chunk-dependencies (960cec9) with main (1a83ce4)

Summary

✅ 17 untouched

@LingyuCoder LingyuCoder merged commit eca5ba6 into main Nov 18, 2025
56 checks passed
@LingyuCoder LingyuCoder deleted the test/startup-chunk-dependencies branch November 18, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants