Merged
Conversation
✅ Deploy Preview for rspack canceled.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the JSON module size calculation to report the actual size of the JSON data instead of the generated module source code with boilerplate.
- Changes the
size()method to calculate size based on stringified JSON data frombuild_inforather than the full generated module source - Updates the size calculation to use
json_datafield directly, providing more accurate module size reporting
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/rspack_plugin_json/src/lib.rs | Modified the size() method to calculate module size from the parsed JSON data instead of the generated source code |
| tests/rspack-test/statsOutputCases/ignore-warnings/snapshots/stats.txt | Updated test snapshot to reflect the corrected module size (797 → 784 bytes) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
📦 Binary Size-limit
❌ Size increased by 768bytes from 47.45MB to 47.45MB (⬆️0.00%) |
CodSpeed Performance ReportMerging #12189 will not alter performanceComparing Summary
|
jerrykingxyz
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix #12173
Related links
Checklist