fix: should not transform [name]/[file] in wasm filename template#12184
Merged
LingyuCoder merged 1 commit intomainfrom Nov 13, 2025
Merged
fix: should not transform [name]/[file] in wasm filename template#12184LingyuCoder merged 1 commit intomainfrom
[name]/[file] in wasm filename template#12184LingyuCoder merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for rspack canceled.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where [name] and [file] placeholders in WebAssembly module filenames were being incorrectly transformed, aligning rspack's behavior with webpack. The fix removes a .filename() call that was causing these unsupported placeholders to be replaced with actual values.
- Removes the
.filename()call from wasm name rendering to prevent unwanted placeholder transformation - Adds a test case to verify that
[name]placeholder remains literal in wasm filename templates - Ensures only supported placeholders (
[id],[hash],[contenthash]) are transformed for wasm files
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/rspack_plugin_wasm/src/parser_and_generator.rs | Removes .filename() call from PathData builder to prevent transformation of [name] and [file] placeholders |
| tests/rspack-test/configCases/wasm/not-support-placeholder/rspack.config.js | Adds test configuration to verify [name] placeholder remains literal in output |
| tests/rspack-test/configCases/wasm/not-support-placeholder/index.js | Adds test case importing and testing wasm functionality |
| tests/rspack-test/configCases/wasm/not-support-placeholder/factorial.wasm | Adds wasm binary file for testing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
📦 Binary Size-limit
❌ Size increased by 128bytes from 48.10MB to 48.10MB (⬆️0.00%) |
CodSpeed Performance ReportMerging #12184 will not alter performanceComparing Summary
|
ahabhgk
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix #11351, align with webpack
Related links
Checklist