fix: should have js entry for importModule assets and rslib#12167
Merged
fix: should have js entry for importModule assets and rslib#12167
Conversation
✅ Deploy Preview for rspack canceled.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where asset entries and loader importModule calls were not generating the necessary JavaScript entry files. The fix ensures that when using importModule to point to assets, or when using RslibPlugin with asset entries, a proper JavaScript module is generated instead of an empty result.
Key changes:
- Modified the
AssetParserAndGeneratorto include JavaScript source type for loader imports - Created a wrapper
RslibAssetParserAndGeneratorto customize source types for asset entry resources - Changed the
NormalModuleFactoryParserhook signature to useBox<dyn ParserAndGenerator>instead of raw reference
Reviewed Changes
Copilot reviewed 16 out of 20 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
crates/rspack_plugin_asset/src/lib.rs |
Added logic to include JavaScript source type for LoaderImport dependencies and made AssetParserAndGenerator Clone-able |
crates/rspack_plugin_rslib/src/asset.rs |
New wrapper around AssetParserAndGenerator that returns JavaScript+Asset source types for entry resources |
crates/rspack_plugin_rslib/src/plugin.rs |
Integrated RslibAssetParserAndGenerator for asset parsers |
crates/rspack_core/src/normal_module_factory.rs |
Changed parser hook parameter from mutable reference to Box |
tests/rspack-test/configCases/loader-import-module/assets/ |
Added test case for loader importModule with assets |
tests/rspack-test/configCases/rslib/asset-entry/ |
Added test case for rslib with asset entry |
| Multiple plugin files | Updated to match new parser hook signature |
crates/rspack_plugin_rslib/Cargo.toml |
Added dependencies needed for asset wrapper |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
📦 Binary Size-limit
❌ Size increased by 5.38KB from 48.09MB to 48.10MB (⬆️0.01%) |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
CodSpeed Performance ReportMerging #12167 will not alter performanceComparing Summary
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Should have a js module when using importModule point to assets, otherwise it will get empty result by importModule. RslibPlugin also needs this js module to implements bundleless features.
Related links
Checklist