refactor: move code splitting cache into artifact#12164
Merged
Conversation
✅ Deploy Preview for rspack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
📦 Binary Size-limit
🙈 Size remains the same at 48.09MB |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the code splitting cache by moving it into a new BuildChunkGraphArtifact structure. This change improves code organization by grouping related build chunk graph artifacts together.
- Introduced
BuildChunkGraphArtifactstruct that wrapsCodeSplittingCache - Updated all references from
compilation.code_splitting_cachetocompilation.build_chunk_graph_artifact.code_splitting_cache - Maintained backwards compatibility by keeping the same functionality
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| crates/rspack_core/src/compiler/rebuild.rs | Updated rebuild logic to swap the entire build_chunk_graph_artifact instead of just code_splitting_cache |
| crates/rspack_core/src/compilation/mod.rs | Added BuildChunkGraphArtifact import and field, removed direct CodeSplittingCache import and field |
| crates/rspack_core/src/compilation/build_chunk_graph/new_code_splitter.rs | Updated all references to access cache through new artifact structure |
| crates/rspack_core/src/compilation/build_chunk_graph/mod.rs | Updated code splitter access paths through new artifact structure |
| crates/rspack_core/src/compilation/build_chunk_graph/artifact.rs | Defined new BuildChunkGraphArtifact struct and updated all internal references to use the new path |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CodSpeed Performance ReportMerging #12164 will not alter performanceComparing Summary
|
06a1bd5 to
d9efd23
Compare
JSerFeng
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
move code splitting cache into build_chunk_graph_artifact
Related links
Checklist