refactor: move build_chunk_graph into compilation#12162
Merged
Conversation
✅ Deploy Preview for rspack canceled.
|
Contributor
📦 Binary Size-limit
❌ Size increased by 128bytes from 48.09MB to 48.09MB (⬆️0.00%) |
CodSpeed Performance ReportMerging #12162 will not alter performanceComparing Summary
|
JSerFeng
approved these changes
Nov 12, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the codebase by moving the build_chunk_graph module from the top-level rspack_core into the compilation folder. The main changes include:
- Moving
build_chunk_graphmodule intocompilation/build_chunk_graph - Creating a new
artifact.rsfile containing code splitting cache functionality previously inold_cache/local/code_splitting_cache.rs - Adding new code splitter implementations in
new_code_splitter.rs,code_splitter.rs,incremental.rs, andavailable_modules.rs - Removing the old cache module references
Reviewed Changes
Copilot reviewed 5 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
crates/rspack_core/src/lib.rs |
Removed public export of build_chunk_graph module |
crates/rspack_core/src/compilation/mod.rs |
Added build_chunk_graph as a submodule and imported its public items |
crates/rspack_core/src/old_cache/mod.rs |
Removed local module and its export |
crates/rspack_core/src/old_cache/local/mod.rs |
Deleted file containing code_splitting_cache export |
crates/rspack_core/src/compilation/build_chunk_graph/*.rs |
New files containing moved/refactored code splitting logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
move build_chunk_graph into compilation folder
Follow up:
Related links
Checklist