chore: update rspack resolver to v0.6.6#12149
Merged
Conversation
✅ Deploy Preview for rspack canceled.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the rspack_resolver dependency from version 0.6.4 to 0.6.5, along with necessary code adaptations for API changes in the new version.
- Updated
rspack_resolverfrom 0.6.4 to 0.6.5 - Removed unnecessary
.and_then(|t| t.as_str())call in resolver code, reflecting API changes wherer#typenow returns a type that directly implementsToString - Updated transitive dependencies including
thiserror,pnp,simd-json, and various other libraries
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Cargo.toml | Bumped rspack_resolver version from 0.6.4 to 0.6.5 |
| Cargo.lock | Updated dependency tree including rspack_resolver and transitive dependencies (pnp, thiserror, simd-json, fancy-regex, etc.) |
| crates/rspack_binding_api/src/rspack_resolver/mod.rs | Removed redundant .and_then(|t| t.as_str()) call now that r#type field returns a type implementing ToString directly |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
📦 Binary Size-limit
❌ Size increased by 86.88KB from 47.48MB to 47.57MB (⬆️0.18%) |
CodSpeed Performance ReportMerging #12149 will not alter performanceComparing Summary
|
737248b to
6a3ca82
Compare
1 task
1 task
0912675 to
5d5fc1b
Compare
hardfist
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
update to https://github.com/web-infra-dev/rspack-resolver/releases/tag/v0.6.6
why patch.crates-io
Due to
simd-adler32's wasm compile error being fixed but not published to crates.io yetRelated links
Checklist