Skip to content

perf: fix drop regression#11649

Merged
LingyuCoder merged 1 commit intomainfrom
perf/fix-drop-regression
Sep 12, 2025
Merged

perf: fix drop regression#11649
LingyuCoder merged 1 commit intomainfrom
perf/fix-drop-regression

Conversation

@LingyuCoder
Copy link
Contributor

@LingyuCoder LingyuCoder commented Sep 12, 2025 •
edited
Loading

Summary

Revert async droping of exports info data that introduced in #11611 which caused performance regression in benchmark

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings September 12, 2025 05:54
@netlify
Copy link

netlify bot commented Sep 12, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit bf0853c
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/68c3b5864f1e3a00083daf78

Copilot AI reviewed Sep 12, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a performance regression in the drop mechanism for exports info management by removing an unnecessary asynchronous spawn operation.

  • Removed rayon::spawn call that was used to drop the old value asynchronously
  • Simplified the set_exports_info method to use direct insertion without explicit drop handling

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: performance release: performance related release(mr only) labels Sep 12, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 12, 2025 •
edited
Loading

📝 Benchmark detail: Open

Name Base (2025-09-12 293975c) Current Change
10000_big_production-mode_disable-minimize + exec 28.2 s ± 611 ms 28.2 s ± 1.07 s -0.05 %
10000_development-mode + exec 1.9 s ± 63 ms 1.63 s ± 34 ms -14.54 %
10000_development-mode_hmr + exec 701 ms ± 8.9 ms 701 ms ± 21 ms -0.06 %
10000_development-mode_noop-loader + exec 2.77 s ± 75 ms 2.61 s ± 146 ms -5.98 %
10000_production-mode + exec 1.86 s ± 53 ms 1.67 s ± 32 ms -10.59 %
10000_production-mode_persistent-cold + exec 2.05 s ± 55 ms 1.89 s ± 232 ms -7.78 %
10000_production-mode_persistent-hot + exec 1.38 s ± 42 ms 1.37 s ± 22 ms -0.29 %
arco-pro_development-mode + exec 1.79 s ± 82 ms 1.77 s ± 111 ms -1.14 %
arco-pro_development-mode_hmr + exec 369 ms ± 0.65 ms 369 ms ± 1.5 ms -0.05 %
arco-pro_production-mode + exec 3.3 s ± 71 ms 3.17 s ± 47 ms -3.94 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.31 s ± 114 ms 3.27 s ± 64 ms -1.07 %
arco-pro_production-mode_persistent-cold + exec 3.34 s ± 78 ms 3.34 s ± 238 ms +0.21 %
arco-pro_production-mode_persistent-hot + exec 2 s ± 94 ms 2.01 s ± 60 ms +0.45 %
arco-pro_production-mode_traverse-chunk-modules + exec 3.27 s ± 69 ms 3.23 s ± 181 ms -1.36 %
large-dyn-imports_development-mode + exec 2.34 s ± 18 ms 1.89 s ± 125 ms -19.35 %
large-dyn-imports_production-mode + exec 2.18 s ± 66 ms 1.85 s ± 20 ms -15.36 %
threejs_development-mode_10x + exec 1.53 s ± 28 ms 1.48 s ± 28 ms -3.22 %
threejs_development-mode_10x_hmr + exec 947 ms ± 31 ms 944 ms ± 21 ms -0.35 %
threejs_production-mode_10x + exec 4.53 s ± 184 ms 4.51 s ± 82 ms -0.43 %
threejs_production-mode_10x_persistent-cold + exec 4.7 s ± 353 ms 4.68 s ± 304 ms -0.37 %
threejs_production-mode_10x_persistent-hot + exec 4.1 s ± 78 ms 4.15 s ± 142 ms +1.17 %
10000_big_production-mode_disable-minimize + rss memory 8553 MiB ± 526 MiB 8613 MiB ± 265 MiB +0.70 %
10000_development-mode + rss memory 691 MiB ± 22.4 MiB 670 MiB ± 16.3 MiB -3.08 %
10000_development-mode_hmr + rss memory 828 MiB ± 41.6 MiB 797 MiB ± 17.5 MiB -3.84 %
10000_development-mode_noop-loader + rss memory 974 MiB ± 29.4 MiB 955 MiB ± 22.1 MiB -2.03 %
10000_production-mode + rss memory 653 MiB ± 47 MiB 648 MiB ± 49.5 MiB -0.79 %
10000_production-mode_persistent-cold + rss memory 762 MiB ± 18.1 MiB 765 MiB ± 38.9 MiB +0.43 %
10000_production-mode_persistent-hot + rss memory 744 MiB ± 45.1 MiB 762 MiB ± 42.8 MiB +2.47 %
arco-pro_development-mode + rss memory 568 MiB ± 54.6 MiB 563 MiB ± 51.1 MiB -0.90 %
arco-pro_development-mode_hmr + rss memory 468 MiB ± 8.19 MiB 459 MiB ± 9.78 MiB -1.80 %
arco-pro_production-mode + rss memory 688 MiB ± 78.1 MiB 667 MiB ± 64.6 MiB -3.09 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory 681 MiB ± 126 MiB 695 MiB ± 60.2 MiB +2.00 %
arco-pro_production-mode_persistent-cold + rss memory 778 MiB ± 101 MiB 762 MiB ± 51.9 MiB -2.10 %
arco-pro_production-mode_persistent-hot + rss memory 657 MiB ± 86.6 MiB 624 MiB ± 103 MiB -5.03 %
arco-pro_production-mode_traverse-chunk-modules + rss memory 705 MiB ± 39 MiB 678 MiB ± 40.2 MiB -3.78 %
large-dyn-imports_development-mode + rss memory 690 MiB ± 8.99 MiB 685 MiB ± 3.73 MiB -0.61 %
large-dyn-imports_production-mode + rss memory 590 MiB ± 5.52 MiB 587 MiB ± 3.14 MiB -0.54 %
threejs_development-mode_10x + rss memory 592 MiB ± 22.5 MiB 588 MiB ± 19.8 MiB -0.73 %
threejs_development-mode_10x_hmr + rss memory 836 MiB ± 60.4 MiB 826 MiB ± 36.9 MiB -1.14 %
threejs_production-mode_10x + rss memory 797 MiB ± 198 MiB 801 MiB ± 192 MiB +0.53 %
threejs_production-mode_10x_persistent-cold + rss memory 820 MiB ± 58.8 MiB 800 MiB ± 11.5 MiB -2.52 %
threejs_production-mode_10x_persistent-hot + rss memory 708 MiB ± 34.1 MiB 708 MiB ± 38.8 MiB -0.02 %

@github-actions
Copy link
Contributor

github-actions bot commented Sep 12, 2025

📦 Binary Size-limit

Comparing bf0853c to refactor: remove expect for lazy barrel pending forwarded ids (#11646) by Gengkun

❌ Size increased by 2.38KB from 47.43MB to 47.43MB (⬆️0.00%)

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 12, 2025

CodSpeed Performance Report

Merging #11649 will not alter performance

Comparing perf/fix-drop-regression (bf0853c) with main (293975c)

🎉 Hooray! codspeed-node just leveled up to 4.0.1!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 17 untouched

@LingyuCoder LingyuCoder requested a review from SyMind September 12, 2025 06:31
@LingyuCoder LingyuCoder merged commit 8be291d into main Sep 12, 2025
49 checks passed
@LingyuCoder LingyuCoder deleted the perf/fix-drop-regression branch September 12, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@SyMind SyMind SyMind approved these changes

Assignees

No one assigned

Labels

release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LingyuCoder @SyMind