chore(ci): add fallback value for scheduled workflow run#11641
Merged
stormslowly merged 1 commit intomainfrom Sep 11, 2025
Merged
chore(ci): add fallback value for scheduled workflow run#11641stormslowly merged 1 commit intomainfrom
stormslowly merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for rspack canceled.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the release-canary.yml workflow to handle scheduled workflow runs by adding fallback values for inputs that are undefined when the workflow is triggered by a cron schedule rather than manual dispatch.
- Add fallback values for
commit,profile, andtestinputs in the reusable build workflow call - Ensure the workflow works correctly for both scheduled runs and manual dispatch
Comments suppressed due to low confidence (1)
.github/workflows/release-canary.yml:1
- The
refparameter in the checkout step also needs a fallback value to handle scheduled workflow runs. It should use${{inputs.commit || github.sha}}to be consistent with the build job.
name: Release Canary
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
📦 Binary Size-limit
🙈 Size remains the same at 47.23MB |
CodSpeed Performance ReportMerging #11641 will not alter performanceComparing Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Schduled workflow run doesn't have inputs.
So fallback values should be provided
Verified by forked repo https://github.com/stormslowly/rspack/actions/runs/17633394874
Related links
Checklist