Skip to content

fix: mark import.meta.webpackHot type as optional#11638

Merged
chenjiahan merged 3 commits intoweb-infra-dev:mainfrom
yf-yang:main
Sep 11, 2025
Merged

fix: mark import.meta.webpackHot type as optional#11638
chenjiahan merged 3 commits intoweb-infra-dev:mainfrom
yf-yang:main

Conversation

@yf-yang
Copy link
Contributor

@yf-yang yf-yang commented Sep 11, 2025

Summary

closes #11631

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@yf-yang yf-yang requested a review from hardfist as a code owner September 11, 2025 02:11
@netlify
Copy link

netlify bot commented Sep 11, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 6eab372
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/68c24bdb09b26e000867bc21

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Sep 11, 2025
chenjiahan
chenjiahan reviewed Sep 11, 2025
View reviewed changes
chenjiahan
chenjiahan previously approved these changes Sep 11, 2025
View reviewed changes
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@chenjiahan chenjiahan enabled auto-merge (squash) September 11, 2025 02:23
@yf-yang
Copy link
Contributor Author

yf-yang commented Sep 11, 2025

Would you like to update this line, too?

rspack/packages/rspack/module.d.ts

Line 180 in 9dd9d3d

hot?: Hot | undefined;

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 11, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #11638 will not alter performance

Comparing yf-yang:main (6eab372) with main (9dd9d3d)

🎉 Hooray! codspeed-rust just leveled up to 2.7.2!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 17 untouched benchmarks

@chenjiahan
Copy link
Member

chenjiahan commented Sep 11, 2025

Would you like to update this line, too?

rspack/packages/rspack/module.d.ts

Line 180 in 9dd9d3d

hot?: Hot | undefined;

That would be great

auto-merge was automatically disabled September 11, 2025 04:11

Head branch was pushed to by a user without write access

@chenjiahan chenjiahan enabled auto-merge (squash) September 11, 2025 04:15
@chenjiahan chenjiahan merged commit acf1e15 into web-infra-dev:main Sep 11, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

@hardfist hardfist Awaiting requested review from hardfist hardfist is a code owner

Assignees

No one assigned

Labels

release: bug fix release: bug related release(mr only)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature]: Mark import.meta.webpackHot type signature as optional

2 participants

@yf-yang @chenjiahan