Skip to content

chore: make @rspack/tests private#11636

Merged
stormslowly merged 1 commit intomainfrom
chore/private_tests_rspack
Sep 10, 2025
Merged

chore: make @rspack/tests private#11636
stormslowly merged 1 commit intomainfrom
chore/private_tests_rspack

Conversation

@stormslowly
Copy link
Contributor

@stormslowly stormslowly commented Sep 10, 2025 •
edited
Loading

Summary

Found by canary release.

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings September 10, 2025 13:35
@netlify
Copy link

netlify bot commented Sep 10, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 601f7e3
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/68c17e8c57417300089273a4

Copilot AI reviewed Sep 10, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR marks the @rspack/tests package as private to prevent it from being published to npm registries.

  • Adds the "private": true field to the package.json configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Sep 10, 2025
@stormslowly stormslowly enabled auto-merge (squash) September 10, 2025 13:38
@github-actions
Copy link
Contributor

github-actions bot commented Sep 10, 2025 •
edited
Loading

📦 Binary Size-limit

Comparing 601f7e3 to feat: throw specified error to indicate undefined factory case in HMR (#11584) by pshu

🙈 Size remains the same at 47.23MB

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 10, 2025

CodSpeed Performance Report

Merging #11636 will not alter performance

Comparing chore/private_tests_rspack (601f7e3) with main (6aef3a3)

🎉 Hooray! codspeed-node just leveled up to 4.0.1!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 17 untouched benchmarks

@stormslowly stormslowly merged commit b74ca68 into main Sep 10, 2025
143 of 155 checks passed
@stormslowly stormslowly deleted the chore/private_tests_rspack branch September 10, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@LingyuCoder LingyuCoder LingyuCoder approved these changes

@chenjiahan chenjiahan chenjiahan approved these changes

Assignees

No one assigned

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stormslowly @LingyuCoder @chenjiahan