fix: persistent cache update issuer is updated modules#11633
Merged
jerrykingxyz merged 3 commits intomainfrom Sep 11, 2025
Merged
fix: persistent cache update issuer is updated modules#11633jerrykingxyz merged 3 commits intomainfrom
jerrykingxyz merged 3 commits intomainfrom
Conversation
✅ Deploy Preview for rspack canceled.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes persistent cache update handling for modules with updated issuers. It adds tracking for modules whose issuer relationships have been modified during the fix_issuers process and ensures these modules are properly updated in the persistent cache.
- Added
issuer_update_modulesfield to track modules with modified issuer relationships - Updated test cases to validate issuer handling logic with improved error checking
- Modified cache persistence to include issuer-updated modules in the update set
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/rspack_core/src/compilation/make/artifact.rs | Added issuer_update_modules field to track modules with updated issuers |
| crates/rspack_core/src/compilation/make/graph_updater/cutout/fix_issuers.rs | Added tracking of issuer updates and fixed helper reuse issue |
| crates/rspack_core/src/cache/persistent/occasion/make/mod.rs | Updated cache persistence to include issuer-updated modules |
| tests/rspack-test/hotCases/make/clean-isolated-cycle/rspack.config.js | Improved issuer validation logic with better error handling |
| tests/rspack-test/cacheCases/make/issuer-update/rspack.config.js | New test case for validating issuer updates with persistent cache |
| tests/rspack-test/cacheCases/make/issuer-update/index.js | Test implementation for issuer update scenarios |
| tests/rspack-test/cacheCases/make/issuer-update/file.js | Test file with multiple states for issuer testing |
| tests/rspack-test/cacheCases/make/issuer-update/b.js | Supporting test module |
| tests/rspack-test/cacheCases/make/issuer-update/a.js | Supporting test module with state changes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
crates/rspack_core/src/compilation/make/graph_updater/cutout/fix_issuers.rs
Show resolved
Hide resolved
e53be34 to
2bffbcf
Compare
2bffbcf to
58f8801
Compare
Contributor
📦 Binary Size-limit
🎉 Size decreased by 1.63KB from 47.23MB to 47.23MB (⬇️0.00%) |
CodSpeed Performance ReportMerging #11633 will not alter performanceComparing Summary
|
LingyuCoder
approved these changes
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The persistent cache will only save the module which has been rebuilt, and ignore the module which update issuer. The behaivor may cause issuer has cycle.
Here a example:
This PR will update the module which issuer has been updated.
Related links
Checklist