fix: revert "fix(rslib): treat module identifier as normal (#11588)"#11630
fix: revert "fix(rslib): treat module identifier as normal (#11588)"#11630
module identifier as normal (#11588)"#11630Conversation
This reverts commit 15ba68e.
✅ Deploy Preview for rspack canceled.
|
There was a problem hiding this comment.
Pull Request Overview
This PR reverts a previous change that treated the module identifier as a normal identifier in Rslib's parser plugin. The revert is necessary because the module identifier hook is commonly used in bundling CommonJS modules and removing it would break bundling functionality in Rslib.
- Removes the
identifiermethod implementation that intercepted themoduleidentifier - Removes associated test code that validated the
moduleidentifier handling - Removes the unused
Identimport from the parser plugin
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/rspack_plugin_rslib/src/parser_plugin.rs | Removes the identifier method and Ident import that handled module identifier interception |
| tests/rspack-test/configCases/rslib/plugin-api/index.js | Removes test function that used module identifier |
| tests/rspack-test/configCases/rslib/plugin-api/test.js | Removes test assertions for module identifier handling |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
module identifier as normal (#11588)"module identifier as normal (#11588)"
📦 Binary Size-limit
🎉 Size decreased by 128bytes from 47.23MB to 47.23MB (⬇️0.00%) |
CodSpeed Performance ReportMerging #11630 will not alter performanceComparing 🎉 Hooray!
|
This reverts commit 15ba68e.
Summary
"modulle"identifier hook is commonly used in bundling CJS module, can't be removed directly. this PR will break bundling in Rslib.Related links
Checklist