Skip to content

docs: remove Preview with stackblitz section#11614

Merged
CPunisher merged 1 commit intomainfrom
09-09-docs/wasm-remove-architecture
Sep 9, 2025
Merged

docs: remove Preview with stackblitz section#11614
CPunisher merged 1 commit intomainfrom
09-09-docs/wasm-remove-architecture

Conversation

@CPunisher
Copy link
Contributor

@CPunisher CPunisher commented Sep 9, 2025

Summary

After #11526 there's no need to do that. I have bumped rspack versions in the examples.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link

netlify bot commented Sep 9, 2025

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 6dc389b
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/68bfd2f4c363e300080e25bb
😎 Deploy Preview https://deploy-preview-11614--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the "Preview with StackBlitz" section from the documentation, as it's no longer needed after the changes in pull request #11526. The PR also includes a code update to remove attribution comments from a WebContainer fallback module.

  • Removed the StackBlitz preview documentation section from both English and Chinese quick-start guides
  • Cleaned up attribution comments in the WebContainer fallback module

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
website/docs/zh/guide/start/quick-start.mdx Removed Chinese documentation section about StackBlitz preview setup
website/docs/en/guide/start/quick-start.mdx Removed English documentation section about StackBlitz preview setup
crates/node_binding/webcontainer-fallback.cjs Removed attribution comment header

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot added release: document release: document related release(mr only) team The issue/pr is created by the member of Rspack. labels Sep 9, 2025
@CPunisher CPunisher enabled auto-merge (squash) September 9, 2025 07:11
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2025

📦 Binary Size-limit

Comparing 6dc389b to feat(browser): add postprocess and ResolvedRequest to BrowserHttpImportEsmPlugin (#11571) by CPunisher

🙈 Size remains the same at 47.23MB

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 9, 2025

CodSpeed Performance Report

Merging #11614 will not alter performance

Comparing 09-09-docs/wasm-remove-architecture (6dc389b) with main (12a6349)

Summary

✅ 17 untouched benchmarks

@CPunisher CPunisher merged commit 2634a6e into main Sep 9, 2025
73 of 75 checks passed
@CPunisher CPunisher deleted the 09-09-docs/wasm-remove-architecture branch September 9, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: document release: document related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants