perf: parallelize flag usage plugin#11128
Merged
LingyuCoder merged 1 commit intomainfrom Jul 22, 2025
Merged
Conversation
Contributor
✅ Deploy Preview for rspack canceled.
|
Contributor
📦 Binary Size-limit
❌ Size increased by 16.13KB from 48.95MB to 48.97MB (⬆️0.03%) |
Contributor
|
📝 Benchmark detail: Open
|
CodSpeed Performance ReportMerging #11128 will not alter performanceComparing 🎉 Hooray!
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR parallelizes the flag dependency usage plugin to improve build performance by processing modules in batches using Rayon's parallel iterators while maintaining a queue and cache to avoid redundant computations.
- Refactored the main processing loop to collect modules into batches and process them in parallel
- Extracted logic into separate functions (
merge_referenced_exports,collect_active_dependencies,get_dependency_referenced_exports) for better modularity and parallelization - Added an
is_empty()method to the Queue utility for proper batch processing control
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| crates/rspack_util/src/queue.rs | Added is_empty() method to support batch processing logic |
| crates/rspack_plugin_javascript/src/plugin/flag_dependency_usage_plugin.rs | Complete refactoring to support parallel processing with extracted helper functions and batch-based module processing |
crates/rspack_plugin_javascript/src/plugin/flag_dependency_usage_plugin.rs
Show resolved
Hide resolved
crates/rspack_plugin_javascript/src/plugin/flag_dependency_usage_plugin.rs
Show resolved
Hide resolved
crates/rspack_plugin_javascript/src/plugin/flag_dependency_usage_plugin.rs
Show resolved
Hide resolved
ahabhgk
approved these changes
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a new implement of flag dependency usage plugin strategy just like the part of #10712 but consider of the get mode cache and repeat modules. The same is process modules in batches but keep
Queueand cache to avoid repeat computing.And also this PR has been tested in rome case and will not lead to performance regression.
Before:
After:
Related links
Checklist