Skip to content

fix: remove incorrect expect#10930

Merged
JSerFeng merged 1 commit intomainfrom
chore/remove-incorrect-expect
Jul 7, 2025
Merged

fix: remove incorrect expect#10930
JSerFeng merged 1 commit intomainfrom
chore/remove-incorrect-expect

Conversation

@JSerFeng
Copy link
Copy Markdown
Contributor

@JSerFeng JSerFeng commented Jul 7, 2025

Summary

Some expect() assertions is not correct, module can missing if it has build error in the earlier phase

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link
Copy Markdown

netlify bot commented Jul 7, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit cea44a0
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/686b873102767800081841c2

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Jul 7, 2025
@JSerFeng JSerFeng enabled auto-merge (squash) July 7, 2025 08:40
@JSerFeng JSerFeng changed the title fix: remove unnecessary expect fix: remove incorrect expect Jul 7, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 7, 2025

📦 Binary Size-limit

Comparing binary size with Commit: feat: report module file and loc for dependency diagnostic (#10924) by Cong-Cong Pan

🎉 Size decreased by 896bytes from 59.95MB to 59.94MB (⬇️0.00%)

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Jul 7, 2025

CodSpeed Performance Report

Merging #10930 will not alter performance

Comparing chore/remove-incorrect-expect (cea44a0) with main (d2d9f75)

Summary

✅ 16 untouched benchmarks

@JSerFeng JSerFeng merged commit bc8d053 into main Jul 7, 2025
75 of 77 checks passed
@JSerFeng JSerFeng deleted the chore/remove-incorrect-expect branch July 7, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants